Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)

From	Tejun Heo <htejun@gmail.com>
Newsgroups	linux.kernel
Subject	Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)
Date	2015-09-17 19:20 +0200
Message-ID	<q9L0K-1KM-15@gated-at.bofh.it> (permalink)
References	(1 earlier) <q9vfk-3Em-15@gated-at.bofh.it> <q9A5j-2mG-3@gated-at.bofh.it> <q9Icx-607-7@gated-at.bofh.it> <q9JV1-bo-35@gated-at.bofh.it> <q9KxJ-W9-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Thu, Sep 17, 2015 at 09:48:37AM -0700, James Bottomley wrote:
> Well, there's an easy fix for that.  We could have ida_remove() actually
> free the bitmap and not cache it if it's the last layer.  That way ida
> would naturally empty and we wouldn't need a destructor.   Tejun, would
> that work?

Yeah, that definitely is one way to go about it.  It kinda muddles the
purpose of ida_destroy() tho.  I suppose we can rename it to
idr_remove_all() and then do the same to idr.  I'm not particularly
objecting to all that but what's wrong with just calling idr_destroy()
on exit paths?  If missing the call in modules is an issue, maybe we
can just annotate idr/ida with debugobj?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/2] Fix memory leaks in virtio & remoteproc cores Suman Anna <s-anna@ti.com> - 2015-09-17 02:30 +0200
  [PATCH 2/2] remoteproc: fix memory leak of remoteproc ida cache layers Suman Anna <s-anna@ti.com> - 2015-09-17 02:30 +0200
  [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers Suman Anna <s-anna@ti.com> - 2015-09-17 02:30 +0200
    DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio: fix  memory leak of virtio ida cache layers) "Michael S. Tsirkin" <mst@redhat.com> - 2015-09-17 07:40 +0200
      Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix  memory leak of virtio ida cache layers) Hannes Reinecke <hare@suse.de> - 2015-09-17 09:00 +0200
        Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix  memory leak of virtio ida cache layers) Suman Anna <s-anna@ti.com> - 2015-09-18 00:40 +0200
      Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-17 16:20 +0200
        Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) Tejun Heo <htejun@gmail.com> - 2015-09-17 17:20 +0200
        Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) "Michael S. Tsirkin" <mst@redhat.com> - 2015-09-17 18:10 +0200
          Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-17 18:50 +0200
            Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) Tejun Heo <htejun@gmail.com> - 2015-09-17 19:20 +0200
              Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-17 20:00 +0200
                Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) Tejun Heo <htejun@gmail.com> - 2015-09-17 20:10 +0200

csiph-web