Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1221017
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Linus Torvalds <torvalds@linux-foundation.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" |
| Date | Tue, 08 Sep 2015 19:50:01 +0200 |
| Message-ID | <q6vbP-2PL-5@gated-at.bofh.it> (permalink) |
| References | <q6uIN-2hN-7@gated-at.bofh.it> <q6uIN-2hN-5@gated-at.bofh.it> <q6v2b-2Em-19@gated-at.bofh.it> |
| X-Original-To | Oleg Nesterov <oleg@redhat.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=d4LEXzulICfXdGQp1H2rvx80/pgDNvhCsylXhAwld1Q=; b=W+7LyB3aDkh2pni6z7w1SHdPNDRuW7lmgCbX7lfWX5yvlThy//ZFxyoO3rnH/saL1P wcZS8gHATQHYFp7vrvNx5qmZlZXFwobZkN/A3EAZ2A+qdav+sPuTWc/X4vZGlHs8+u/g dnVfPOGkHm5ESqI4ZrOk8gSI/AkIpOjnsm1oN3euyoquzGAFS4jtLlJntNewYJGkAMK5 RICnDH2nRHsEzCKk4KqqpVtOudLkLaT8kV5sC9aTABdeA6t8nhQ433AOmC99izQ5gumV 1oH4OYSqAt0XBEsYMkNbB8BpPFWSNzEPjltALTe6JgrcM8Kw59bhReXsgxW5vHp4R8f0 sggA== |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=d4LEXzulICfXdGQp1H2rvx80/pgDNvhCsylXhAwld1Q=; b=ZsZxf3JIcs9HFy9Jcgd6/FMbW/Q3m0Mb0J3YMU0cVfenKOq88mNSmq00oBo1GOoxqR qzAtWt3SNuGn0l14PmhSHnsVD7ivpWCvSn1Pa4rlqEeDGy0OOzuBfsg3dFJ1pHIshJzs fU+Fv3gPXCDBtCGNhDRHLXn+v2Gpb3T+CXtgg= |
| MIME-Version | 1.0 |
| X-Received | by 10.107.11.166 with SMTP id 38mr22545671iol.186.1441734090247; Tue, 08 Sep 2015 10:41:30 -0700 (PDT) |
| X-Google-Sender-Auth | Xf-FG3UDehQE9kH-O-90g_t87xw |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 19 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Al Viro <viro@zeniv.linux.org.uk>, Eric Dumazet <eric.dumazet@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@kernel.org>, Maciej Żenczykowski <maze@google.com>, Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner <tglx@linutronix.de>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> |
| X-Original-Date | Tue, 8 Sep 2015 10:41:30 -0700 |
| X-Original-Message-ID | <CA+55aFwO=ZLnfkK9CcM3aaHh87F79NbfDPswmMmRh_9DTpHGew@mail.gmail.com> |
| X-Original-References | <20150908171433.GA14573@redhat.com> <20150908171452.GA14599@redhat.com> <CA+55aFy-cd6T+VeFV8WhegZXawzEFZEKN2U44-xLJRB4ww4s4w@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1221017 |
Show key headers only | View raw
On Tue, Sep 8, 2015 at 10:39 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> The other patches I do like - why add those list operations that are
> just guaranteed to mess up the cache to add the file descriptors to
> the workqueue list, when we can just do the operation directly?
Side note, it's not just messing with the cache unnecessarily when the
lists grow long, the "cmpxchg" involved in adding the work is fairly
expensive. It may be an unlocked operation, but it's generally as
expensive as a locked one - just without the possibility of a
deadlock.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Oleg Nesterov <oleg@redhat.com> - 2015-09-08 19:20 +0200
Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Linus Torvalds <torvalds@linux-foundation.org> - 2015-09-08 19:40 +0200
Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Linus Torvalds <torvalds@linux-foundation.org> - 2015-09-08 19:50 +0200
Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Oleg Nesterov <oleg@redhat.com> - 2015-09-09 15:20 +0200
Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Linus Torvalds <torvalds@linux-foundation.org> - 2015-09-09 18:20 +0200
Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Oleg Nesterov <oleg@redhat.com> - 2015-09-09 18:50 +0200
csiph-web