Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1221017

Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee"

Show all headers | View raw

On Tue, Sep 8, 2015 at 10:39 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> The other patches I do like - why add those list operations that are
> just guaranteed to mess up the cache to add the file descriptors to
> the workqueue list, when we can just do the operation directly?

Side note, it's not just messing with the cache unnecessarily when the
lists grow long, the "cmpxchg" involved in adding the work is fairly
expensive. It may be an unlocked operation, but it's generally as
expensive as a locked one - just without the possibility of a
deadlock.

               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Oleg Nesterov <oleg@redhat.com> - 2015-09-08 19:20 +0200
  Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Linus Torvalds <torvalds@linux-foundation.org> - 2015-09-08 19:40 +0200
    Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Linus Torvalds <torvalds@linux-foundation.org> - 2015-09-08 19:50 +0200
    Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Oleg Nesterov <oleg@redhat.com> - 2015-09-09 15:20 +0200
      Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Linus Torvalds <torvalds@linux-foundation.org> - 2015-09-09 18:20 +0200
        Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Oleg Nesterov <oleg@redhat.com> - 2015-09-09 18:50 +0200

csiph-web