Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee"

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee"
Date	2015-09-09 18:50 +0200
Message-ID	<q6QJk-ho-7@gated-at.bofh.it> (permalink)
References	<q6uIN-2hN-7@gated-at.bofh.it> <q6uIN-2hN-5@gated-at.bofh.it> <q6v2b-2Em-19@gated-at.bofh.it> <q6Ns7-48j-31@gated-at.bofh.it> <q6Qgi-8b1-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/09, Linus Torvalds wrote:
>
> On Wed, Sep 9, 2015 at 6:16 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > Again, rightly or not I believe that FIFO makes task_work_add() more useful.
> > Perhaps I am wrong, so far I can only provide the artificial examples...
>
> I'd rather wait until somebody has a real use case. I hate adding
> infrastructure for "what if.." scenarios. We're better off if we can
> make do with minimal semantics (ie "there are no guarantees except
> that the work will be done before returning to user space") than with
> stronger semantics that people then perhaps start depending on even if
> they didn't really need them.

OK, I see. Thanks.

At least you seem to agree with 1-2, so if Al takes these changes we
can easily reconsider 3/3 later, if/when we have the new user which
needs FIFO.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Oleg Nesterov <oleg@redhat.com> - 2015-09-08 19:20 +0200
  Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Linus Torvalds <torvalds@linux-foundation.org> - 2015-09-08 19:40 +0200
    Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Linus Torvalds <torvalds@linux-foundation.org> - 2015-09-08 19:50 +0200
    Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Oleg Nesterov <oleg@redhat.com> - 2015-09-09 15:20 +0200
      Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Linus Torvalds <torvalds@linux-foundation.org> - 2015-09-09 18:20 +0200
        Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Oleg Nesterov <oleg@redhat.com> - 2015-09-09 18:50 +0200

csiph-web