[PATCH 2/2] spi: spi-ep93xx: change PTR_ERR argument

From	Julia Lawall <Julia.Lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] spi: spi-ep93xx: change PTR_ERR argument
Date	2015-08-30 20:20 +0200
Message-ID	<q3fmV-8oI-3@gated-at.bofh.it> (permalink)
References	<q3fmV-8oI-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Apply PTR_ERR to the value that was recently assigned.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,y;
@@

if (IS_ERR(x) || ...) {
  ... when any
      when != IS_ERR(...)
(
   PTR_ERR(x)
|
*  PTR_ERR(y)
)
  ... when any
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/spi/spi-ep93xx.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
index bb00be8..1a7696c 100644
--- a/drivers/spi/spi-ep93xx.c
+++ b/drivers/spi/spi-ep93xx.c
@@ -567,7 +567,8 @@ static void ep93xx_spi_dma_transfer(struct ep93xx_spi *espi)
 	txd = ep93xx_spi_dma_prepare(espi, DMA_MEM_TO_DEV);
 	if (IS_ERR(txd)) {
 		ep93xx_spi_dma_finish(espi, DMA_DEV_TO_MEM);
-		dev_err(&espi->pdev->dev, "DMA TX failed: %ld\n", PTR_ERR(rxd));
+		dev_err(&espi->pdev->dev, "DMA TX failed: %ld\n",
+			PTR_ERR(txd));
 		msg->status = PTR_ERR(txd);
 		return;
 	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/2] change PTR_ERR argument Julia Lawall <Julia.Lawall@lip6.fr> - 2015-08-30 20:20 +0200
  [PATCH 2/2] spi: spi-ep93xx: change PTR_ERR argument Julia Lawall <Julia.Lawall@lip6.fr> - 2015-08-30 20:20 +0200
    Re: [PATCH 2/2] spi: spi-ep93xx: change PTR_ERR argument walter harms <wharms@bfs.de> - 2015-08-30 20:40 +0200
      [PATCH 2/2 v2] spi: spi-ep93xx: fix PTR_ERR problem Julia Lawall <julia.lawall@lip6.fr> - 2015-08-30 22:20 +0200
  [PATCH 1/2] ASoC: qcom: change PTR_ERR argument Julia Lawall <Julia.Lawall@lip6.fr> - 2015-08-30 20:20 +0200
    Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument walter harms <wharms@bfs.de> - 2015-08-30 21:00 +0200
      Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument Julia Lawall <julia.lawall@lip6.fr> - 2015-08-30 22:00 +0200
        Re: [alsa-devel] [PATCH 1/2] ASoC: qcom: change PTR_ERR argument Kenneth Westfield <kwestfie@codeaurora.org> - 2015-09-03 23:40 +0200
      Re: [alsa-devel] [PATCH 1/2] ASoC: qcom: change PTR_ERR argument Kenneth Westfield <kwestfie@codeaurora.org> - 2015-09-03 23:40 +0200
    Re: [alsa-devel] [PATCH 1/2] ASoC: qcom: change PTR_ERR argument Kenneth Westfield <kwestfie@codeaurora.org> - 2015-09-03 23:20 +0200

csiph-web