Re: [PATCH] tracepoint: don't make assumptions about length of string on task rename

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tracepoint: don't make assumptions about length of string on task rename
Date	Tue, 01 Sep 2015 17:40:02 +0200
Message-ID	<q3VPc-2ey-5@gated-at.bofh.it> (permalink)
References	<q2pHJ-1s8-57@gated-at.bofh.it> <q2trY-6Qn-19@gated-at.bofh.it> <q3Vma-1Gq-7@gated-at.bofh.it>
X-Original-To	Sasha Levin <sasha.levin@oracle.com>
X-Session-Marker	726F737465647440676F6F646D69732E6F7267
X-Spam-Summary	2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:3874:5007:6261:7875:10004:10400:10848:10967:11232:11658:11914:12296:12517:12519:12740:13069:13161:13229:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-He-Tag	wool25_50df2d2920538
X-Filterd-Recvd-Size	1567
X-Mailer	Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	mingo@redhat.com, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 1 Sep 2015 11:32:34 -0400
X-Original-Message-ID	<20150901113234.53c1da70@gandalf.local.home>
X-Original-References	<1440760018-1557-1-git-send-email-sasha.levin@oracle.com> <20150828110251.41b6b805@gandalf.local.home> <55E5BF34.8080005@oracle.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1216934

Show key headers only | View raw

On Tue, 01 Sep 2015 11:07:32 -0400
Sasha Levin <sasha.levin@oracle.com> wrote:

 
> > Also, as the memcpy was just faster than a strcpy, the static length
> > was used. Perhaps we should convert that to a dynamic length string.
> > But that should be a separate patch as this one fixes a possible bug,
> > and the conversion to a dynamic string is just an enhancement.
> 
> That'll slow things down for the common case, no?

Not really that much.

The comms should have been dynamic strings too, but the sched_switch
tracepoint (the one others have been copied from) was created before we
had dynamic strings for tracepoints.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tracepoint: don't make assumptions about length of string on task rename Sasha Levin <sasha.levin@oracle.com> - 2015-08-28 13:10 +0200
  Re: [PATCH] tracepoint: don't make assumptions about length of  string on task rename Steven Rostedt <rostedt@goodmis.org> - 2015-08-28 17:10 +0200
    Re: [PATCH] tracepoint: don't make assumptions about length of string  on task rename Sasha Levin <sasha.levin@oracle.com> - 2015-09-01 17:10 +0200
      Re: [PATCH] tracepoint: don't make assumptions about length of  string on task rename Steven Rostedt <rostedt@goodmis.org> - 2015-09-01 17:40 +0200

csiph-web