Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216934

Re: [PATCH] tracepoint: don't make assumptions about length of string on task rename

Show all headers | View raw

On Tue, 01 Sep 2015 11:07:32 -0400
Sasha Levin <sasha.levin@oracle.com> wrote:

 
> > Also, as the memcpy was just faster than a strcpy, the static length
> > was used. Perhaps we should convert that to a dynamic length string.
> > But that should be a separate patch as this one fixes a possible bug,
> > and the conversion to a dynamic string is just an enhancement.
> 
> That'll slow things down for the common case, no?

Not really that much.

The comms should have been dynamic strings too, but the sched_switch
tracepoint (the one others have been copied from) was created before we
had dynamic strings for tracepoints.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tracepoint: don't make assumptions about length of string on task rename Sasha Levin <sasha.levin@oracle.com> - 2015-08-28 13:10 +0200
  Re: [PATCH] tracepoint: don't make assumptions about length of  string on task rename Steven Rostedt <rostedt@goodmis.org> - 2015-08-28 17:10 +0200
    Re: [PATCH] tracepoint: don't make assumptions about length of string  on task rename Sasha Levin <sasha.levin@oracle.com> - 2015-09-01 17:10 +0200
      Re: [PATCH] tracepoint: don't make assumptions about length of  string on task rename Steven Rostedt <rostedt@goodmis.org> - 2015-09-01 17:40 +0200

csiph-web