Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216917

Re: [PATCH] tracepoint: don't make assumptions about length of string on task rename

Show all headers | View raw

On 08/28/2015 11:02 AM, Steven Rostedt wrote:
> On Fri, 28 Aug 2015 07:06:58 -0400
> Sasha Levin <sasha.levin@oracle.com> wrote:
> 
>> While the dest comm string size is assured to be at least TASK_COMM_LEN long,
>> doing a memcpy() also adds the assumption that the source is at least that
>> long as well, which isn't assured, and isn't true in cases such as:
>>
>> 	set_task_comm(worker->task, "kworker/dying");
>>
>> This leads to accessing invalid memory.
>>
>> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> 
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
> 
> Should this go to stable as well?

Yup.

> Also, as the memcpy was just faster than a strcpy, the static length
> was used. Perhaps we should convert that to a dynamic length string.
> But that should be a separate patch as this one fixes a possible bug,
> and the conversion to a dynamic string is just an enhancement.

That'll slow things down for the common case, no?


Thanks,
Sasha

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] tracepoint: don't make assumptions about length of string on task rename Sasha Levin <sasha.levin@oracle.com> - 2015-08-28 13:10 +0200
  Re: [PATCH] tracepoint: don't make assumptions about length of  string on task rename Steven Rostedt <rostedt@goodmis.org> - 2015-08-28 17:10 +0200
    Re: [PATCH] tracepoint: don't make assumptions about length of string  on task rename Sasha Levin <sasha.levin@oracle.com> - 2015-09-01 17:10 +0200
      Re: [PATCH] tracepoint: don't make assumptions about length of  string on task rename Steven Rostedt <rostedt@goodmis.org> - 2015-09-01 17:40 +0200

csiph-web