Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1158309

Re: [GIT PULL 0/6] perf/core improvements and fixes

Show all headers | View raw

* Wangnan (F) <wangnan0@huawei.com> wrote:

> On 2015/6/4 13:48, Ingo Molnar wrote:
> >* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >
> >>Hi Ingo,
> >>
> >>	Please consider applying.
> >>
> >>	One of the next requests probably will have the eBPF work by Wang Nan,
> >>but I am still going thru it and want to test it thoroughly.
> >>
> >>	BTW: Have you looked at it lately? It is at:
> >>
> >>http://lkml.kernel.org/r/1433144296-74992-1-git-send-email-wangnan0@huawei.com
> >>
> >>Super summary from the above cover letter:
> >>
> >>---------------------
> >>It enables 'perf record' to filter events using eBPF programs like:
> >>
> >>  # perf record --event bpf-file.o sleep 1
> >>
> >>Events are selected and filtered according to definitions in bpf-file.o.
> >Looks useful, but I think the UI needs one more tweak: could you fix it to be able
> >to filter based on the eBPF _source_ file, not just the object file?
> >
> >People want to tweak such filters as they profile, so we should use the eBPF
> >source code as the primary interface. We can compile it internally to the .o just
> >fine. The .o file is a totally uninteresting intermediate product in itself.
> >
> >I.e. we need to first think through such profiling workflows from beginning to end
> >before allowing them upstream.
> 
> In a private mail Alexei Starovoitov disscussed with me about this. He said that 
> he is working on a shared object which can compile C program into BPF bytecode 
> on the fly. After he done his work, I think perf can support dtrace-like 
> profiling that, users will be able to feed source code to perf directly on 
> cmdline. He said he can release it on June. I added him to the CC-list.
> 
> However I think the '.o' intermediate is still needed. [...]

So how do you generate the .o? Why cannot the tool, if it sees that the filter 
parameter is eBPF source code, do that automatically?

I.e. you are making the user jump through hoops for no good reason - that's a bad 
UI and a bad workflow. Please don't do that!

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL 0/6] perf/core improvements and fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-04 00:50 +0200
  [PATCH 4/6] perf tools: Move linux/kernel.h to tools/include Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-04 00:50 +0200
  [PATCH 5/6] tools: Move tools/perf/util/include/linux/{list.h,poison.h} to tools/include Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-04 00:50 +0200
  [PATCH 1/6] perf probe: Fix segfault when glob matching function without debuginfo Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-04 00:50 +0200
  [PATCH 3/6] perf machine: Fix the search for the kernel DSO on the unified list Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-04 00:50 +0200
  Re: [GIT PULL 0/6] perf/core improvements and fixes Ingo Molnar <mingo@kernel.org> - 2015-06-04 09:30 +0200
  [EXPERIENCE] My experience on using perf record BPF filter on a real  usecase "Wangnan (F)" <wangnan0@huawei.com> - 2015-06-04 12:30 +0200

csiph-web