Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1158119

[PATCH 3/6] perf machine: Fix the search for the kernel DSO on the unified list

Show all headers | View raw

From: Arnaldo Carvalho de Melo <acme@redhat.com>

When unifying the user_dsos and kernel_dsos a bug was introduced by
inverting the check for dso->kernel, fix it.

Fixes: 3d39ac538629 ("perf machine: No need to have two DSOs lists")
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/n/tip-xnrnq0kams3s2z9ek1wjb506@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/machine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index 2ed61f59d415..4e29e80932e5 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -1149,7 +1149,7 @@ static int machine__process_kernel_mmap_event(struct machine *machine,
 		struct dso *dso;
 
 		list_for_each_entry(dso, &machine->dsos.head, node) {
-			if (dso->kernel && is_kernel_module(dso->long_name))
+			if (!dso->kernel || is_kernel_module(dso->long_name))
 				continue;
 
 			kernel = dso;
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL 0/6] perf/core improvements and fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-04 00:50 +0200
  [PATCH 4/6] perf tools: Move linux/kernel.h to tools/include Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-04 00:50 +0200
  [PATCH 5/6] tools: Move tools/perf/util/include/linux/{list.h,poison.h} to tools/include Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-04 00:50 +0200
  [PATCH 1/6] perf probe: Fix segfault when glob matching function without debuginfo Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-04 00:50 +0200
  [PATCH 3/6] perf machine: Fix the search for the kernel DSO on the unified list Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-06-04 00:50 +0200
  Re: [GIT PULL 0/6] perf/core improvements and fixes Ingo Molnar <mingo@kernel.org> - 2015-06-04 09:30 +0200
  [EXPERIENCE] My experience on using perf record BPF filter on a real  usecase "Wangnan (F)" <wangnan0@huawei.com> - 2015-06-04 12:30 +0200

csiph-web