Re: [PATCH 2/2] time: allow gcc to fold constants when possible

From	Nicholas Mc Guire <der.herr@hofr.at>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] time: allow gcc to fold constants when possible
Date	2015-06-04 09:30 +0200
Message-ID	<pxxLb-27e-17@gated-at.bofh.it> (permalink)
References	<pv9Dk-1JH-5@gated-at.bofh.it> <pv9Dk-1JH-7@gated-at.bofh.it> <pvapI-2Xd-7@gated-at.bofh.it> <px1V0-57l-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 02 Jun 2015, Thomas Gleixner wrote:

> On Thu, 28 May 2015, Joe Perches wrote:
> > On Thu, 2015-05-28 at 19:09 +0200, Nicholas Mc Guire wrote:
> > > To allow constant folding in usecs_to_jiffies() conditionally calls
> > > the HZ dependent _usecs_to_jiffies() helpers or, when gcc can not
> > > figure out constant folding, __usecs_to_jiffies, which is the renamed
> > > original usecs_to_jiffies() function.
> > 
> > Hi Nicholas.
> > 
> > Thanks for following through with this.
> > 
> > The subject might be nicer if it referenced usecs_to_jiffies
> > instead of being a bit generic.
> > 
> > Maybe something like:
> > 
> > time: allow gcc to fold usecs_to_jiffies(constant)
> 
> And for correctness sake the first letter after the colon, i.e. the
> one starting the sentence wants to be uppercase.
> 
added to my list of checks - sorry for being sloppy on that

> I'm going to fix that up all together when applying the lot. No need
> for resend.
>

thanks !
hofrat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] time: allow gcc to fold constants when possible Nicholas Mc Guire <der.herr@hofr.at> - 2015-06-04 09:30 +0200

csiph-web