Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1210498

Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

Show all headers | View raw

Thank you Mita for the review.
Your comments were correct and helpful.
I appreciate your time and effort.

please see inline.

> 2015-08-16 19:14 GMT+09:00 Yaniv Gardi <ygardi@codeaurora.org>:
>> @@ -1208,6 +1510,7 @@ static struct ufs_hba_variant_ops
>> ufs_hba_qcom_vops = {
>>         .resume                 = ufs_qcom_resume,
>>         .dbg_register_dump      = ufs_qcom_dump_dbg_regs,
>>  };
>> +EXPORT_SYMBOL(ufs_hba_qcom_vops);
>
> As I said in the view comment for the patch 5, this shouldn't be exported
> again.

I removed this export at all. it is not needed anymore.

>
>> @@ -775,6 +781,12 @@ static inline int ufshcd_vops_resume(struct ufs_hba
>> *hba, enum ufs_pm_op op)
>>         return 0;
>>  }
>>
>> +static inline void ufshcd_vops_dbg_register_dump(struct ufs_hba *hba)
>> +{
>> +       if (hba->vops && hba->vops->dbg_register_dump)
>> +               hba->vops->dbg_register_dump(hba);
>> +}
>> +
>
> This change should be done in the patch 7?

you are correct.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/8] Fix error message and present UFS variant Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-16 12:20 +0200
  [PATCH v1 5/8] scsi: ufs: creates wrapper functions for vops Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-16 12:20 +0200
    Re: [PATCH v1 5/8] scsi: ufs: creates wrapper functions for vops Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-19 14:20 +0200
  [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-16 12:20 +0200
    Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and  power optimizations Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-18 16:30 +0200
    Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and  power optimizations Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-19 14:20 +0200
      Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and  power optimizations ygardi@codeaurora.org - 2015-08-20 15:40 +0200
  [PATCH v1 4/8] add ufshcd_get_variant ufshcd_set_variant Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-16 12:20 +0200

csiph-web