Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1209801
| From | Akinobu Mita <akinobu.mita@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v1 5/8] scsi: ufs: creates wrapper functions for vops |
| Date | 2015-08-19 14:20 +0200 |
| Message-ID | <pZavw-5CZ-5@gated-at.bofh.it> (permalink) |
| References | <pY3cJ-5x0-3@gated-at.bofh.it> <pY3cK-5x0-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
2015-08-16 19:14 GMT+09:00 Yaniv Gardi <ygardi@codeaurora.org>:
> In order to simplify the code a set of wrapper functions is created
> to test and call each of the variant operations.
>
> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
>
> ---
> drivers/scsi/ufs/ufs-qcom.c | 3 +-
> drivers/scsi/ufs/ufshcd.c | 104 +++++++++++++++++---------------------------
> drivers/scsi/ufs/ufshcd.h | 98 +++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 138 insertions(+), 67 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index 64c54b7..a6b7e10 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -1036,7 +1036,7 @@ void ufs_qcom_clk_scale_notify(struct ufs_hba *hba)
> * The variant operations configure the necessary controller and PHY
> * handshake during initialization.
> */
> -static const struct ufs_hba_variant_ops ufs_hba_qcom_vops = {
> +static struct ufs_hba_variant_ops ufs_hba_qcom_vops = {
Why do we need to drop 'const'?
> .name = "qcom",
> .init = ufs_qcom_init,
> .exit = ufs_qcom_exit,
> @@ -1049,6 +1049,5 @@ static const struct ufs_hba_variant_ops ufs_hba_qcom_vops = {
> .suspend = ufs_qcom_suspend,
> .resume = ufs_qcom_resume,
> };
> -EXPORT_SYMBOL(ufs_hba_qcom_vops);
In patch 8, ufs_hba_qcom_vops is exported again...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v1 0/8] Fix error message and present UFS variant Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-16 12:20 +0200
[PATCH v1 5/8] scsi: ufs: creates wrapper functions for vops Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-16 12:20 +0200
Re: [PATCH v1 5/8] scsi: ufs: creates wrapper functions for vops Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-19 14:20 +0200
[PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-16 12:20 +0200
Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-18 16:30 +0200
Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-19 14:20 +0200
Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations ygardi@codeaurora.org - 2015-08-20 15:40 +0200
[PATCH v1 4/8] add ufshcd_get_variant ufshcd_set_variant Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-16 12:20 +0200
csiph-web