Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1210499

Re: [PATCH 03/10] mm, page_alloc: Remove unnecessary recalculations for dirty zone balancing

From Mel Gorman <mgorman@techsingularity.net>
Newsgroups linux.kernel
Subject Re: [PATCH 03/10] mm, page_alloc: Remove unnecessary recalculations for dirty zone balancing
Date 2015-08-20 15:50 +0200
Message-ID <pZyod-6xg-51@gated-at.bofh.it> (permalink)
References <pWBLz-1Xg-7@gated-at.bofh.it> <pWBLA-1Xg-29@gated-at.bofh.it> <pZxs5-57Q-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Aug 20, 2015 at 02:45:27PM +0200, Michal Hocko wrote:
> On Wed 12-08-15 11:45:28, Mel Gorman wrote:
> > File-backed pages that will be immediately are balanced between zones but
> 					    ^written to...
> 
> > it's unnecessarily expensive.
> 
> to do WHAT? I guess you meant checking gfp_mask resp. alloc_mask? I
> doubt it would make a noticeable difference as this is a slow path
> already but I agree it doesn't make sense to check it again.
> 

File-backed pages that will be immediately written are balanced between
zones.  This heuristic tries to avoid having a single zone filled with
recently dirtied pages but the checks are unnecessarily expensive. Move
consider_zone_balanced into the alloc_context instead of checking bitmaps
multiple times. The patch also gives the parameter a more meaningful name.

?

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 03/10] mm, page_alloc: Remove unnecessary recalculations for dirty zone balancing Mel Gorman <mgorman@techsingularity.net> - 2015-08-12 12:50 +0200
  Re: [PATCH 03/10] mm, page_alloc: Remove unnecessary recalculations  for dirty zone balancing Michal Hocko <mhocko@kernel.org> - 2015-08-20 14:50 +0200
    Re: [PATCH 03/10] mm, page_alloc: Remove unnecessary recalculations  for dirty zone balancing Mel Gorman <mgorman@techsingularity.net> - 2015-08-20 15:50 +0200
      Re: [PATCH 03/10] mm, page_alloc: Remove unnecessary recalculations  for dirty zone balancing Michal Hocko <mhocko@kernel.org> - 2015-08-20 16:30 +0200

csiph-web