Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208893

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

Show all headers | View raw

On 08/17/2015 03:45 PM, Guenter Roeck wrote:
> Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
> the call to smsc911x_probe_config() unconditional, and no longer fails if
> there is no device node. device_get_phy_mode() is called unconditionally,
> and if there is no phy node configured returns an error code. This error
> code is assigned to phy_interface, and interpreted elsewhere in the code
> as valid phy mode. This in turn causes qemu to crash when running a
> variant of realview_pb_defconfig.

Thanks for catching that! I have a couple other minor cleanups per the 
reviewers.


         Jeremy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used Guenter Roeck <linux@roeck-us.net> - 2015-08-17 22:50 +0200
  Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF  is configured or used David Miller <davem@davemloft.net> - 2015-08-17 23:10 +0200
  Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is  configured or used Jeremy Linton <jeremy.linton@arm.com> - 2015-08-17 23:20 +0200
    Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF  is configured or used Guenter Roeck <linux@roeck-us.net> - 2015-08-18 00:20 +0200
      Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is  configured or used Jeremy Linton <jeremy.linton@arm.com> - 2015-08-18 00:40 +0200

csiph-web