Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1208928
| From | Jeremy Linton <jeremy.linton@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used |
| Date | 2015-08-18 00:40 +0200 |
| Message-ID | <pYBeq-407-15@gated-at.bofh.it> (permalink) |
| References | <pYzvY-1vo-27@gated-at.bofh.it> <pYzYZ-2iz-11@gated-at.bofh.it> <pYAV4-3DY-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 08/17/2015 05:14 PM, Guenter Roeck wrote: > One nitpick I noticed after sending my patch: dev can never be NULL in > smsc911x_probe_config(), so it does not really make sense to check if it is NULL. No, it doesn't... it should really be something like if (dev_fwnode(dev)) But dev_fwnode is static inline in property.c, and i'm pretty sure that still isn't 100% correct.The best plan might just be to remove the check, and abort on failure to find the phy property per your patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used Guenter Roeck <linux@roeck-us.net> - 2015-08-17 22:50 +0200
Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used David Miller <davem@davemloft.net> - 2015-08-17 23:10 +0200
Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used Jeremy Linton <jeremy.linton@arm.com> - 2015-08-17 23:20 +0200
Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used Guenter Roeck <linux@roeck-us.net> - 2015-08-18 00:20 +0200
Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used Jeremy Linton <jeremy.linton@arm.com> - 2015-08-18 00:40 +0200
csiph-web