Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1208889
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used |
| Date | 2015-08-17 23:10 +0200 |
| Message-ID | <pYzPk-27r-31@gated-at.bofh.it> (permalink) |
| References | <pYzvY-1vo-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Guenter Roeck <linux@roeck-us.net>
Date: Mon, 17 Aug 2015 13:45:36 -0700
> Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
> the call to smsc911x_probe_config() unconditional, and no longer fails if
> there is no device node. device_get_phy_mode() is called unconditionally,
> and if there is no phy node configured returns an error code. This error
> code is assigned to phy_interface, and interpreted elsewhere in the code
> as valid phy mode. This in turn causes qemu to crash when running a
> variant of realview_pb_defconfig.
>
> qemu: hardware error: lan9118_read: Bad reg 0x86
>
> Fixes: 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT")
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> Cc Graeme Gregory <graeme.gregory@linaro.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used Guenter Roeck <linux@roeck-us.net> - 2015-08-17 22:50 +0200
Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used David Miller <davem@davemloft.net> - 2015-08-17 23:10 +0200
Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used Jeremy Linton <jeremy.linton@arm.com> - 2015-08-17 23:20 +0200
Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used Guenter Roeck <linux@roeck-us.net> - 2015-08-18 00:20 +0200
Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used Jeremy Linton <jeremy.linton@arm.com> - 2015-08-18 00:40 +0200
csiph-web