Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1198684

Re: [PATCH] x86: Clean up files of Intel Processor Trace

From Alexander Shishkin <alexander.shishkin@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH] x86: Clean up files of Intel Processor Trace
Date 2015-08-03 11:50 +0200
Message-ID <pTkxB-7HQ-33@gated-at.bofh.it> (permalink)
References <pTj8u-5Oc-19@gated-at.bofh.it> <pTjUS-6Yc-3@gated-at.bofh.it> <pTjUS-6Yc-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 3 August 2015 at 12:08, Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, Aug 03, 2015 at 12:03:13PM +0300, Alexander Shishkin wrote:
>> Takao Indoh <indou.takao@jp.fujitsu.com> writes:
>
>> Even though TOPA_SHIFT happens to be the same as PAGE_SHIFT, it is a
>> property of a separate hardware block, not mmu. PAGE_SHIFT is 12, but
>> 12 is not always PAGE_SHIFT.
>
> PAGE_SHIFT is _always_ 12 on x86. Changing that will require changing
> the page table format, a rather unlikely thing to go happen.

Of course. Yet that doesn't justify turning every 12 into PAGE_SHIFT
is what I'm saying.

Oh, look, it's PAGE_SHIFT o'clock on x86, time for lunch. :)

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] x86: Clean up files of Intel Processor Trace Takao Indoh <indou.takao@jp.fujitsu.com> - 2015-08-03 10:20 +0200
  Re: [PATCH] x86: Clean up files of Intel Processor Trace Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-08-03 11:10 +0200
    Re: [PATCH] x86: Clean up files of Intel Processor Trace Peter Zijlstra <peterz@infradead.org> - 2015-08-03 11:10 +0200
      Re: [PATCH] x86: Clean up files of Intel Processor Trace Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-08-03 11:50 +0200
        Re: [PATCH] x86: Clean up files of Intel Processor Trace Takao Indoh <indou.takao@jp.fujitsu.com> - 2015-08-04 03:10 +0200
      Re: [PATCH] x86: Clean up files of Intel Processor Trace Borislav Petkov <bp@alien8.de> - 2015-08-03 13:10 +0200
        Re: [PATCH] x86: Clean up files of Intel Processor Trace Takao Indoh <indou.takao@jp.fujitsu.com> - 2015-08-04 03:20 +0200

csiph-web