Groups > linux.kernel > #1190948

Re: [PATCH 1/2] PM / devfreq: exynos-ppmu: Add the support of PPMUv2 for Exynos5433

From	Chanwoo Choi <cwchoi00@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] PM / devfreq: exynos-ppmu: Add the support of PPMUv2 for Exynos5433
Date	2015-07-23 16:20 +0200
Message-ID	<pPpvQ-Ga-3@gated-at.bofh.it> (permalink)
References	<pPdXI-I3-3@gated-at.bofh.it> <pPdXI-I3-7@gated-at.bofh.it> <pPliz-2VS-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 23, 2015 at 11:43 AM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> On Thu, Jul 23, 2015 at 10:57:18AM +0900, Chanwoo Choi wrote:
>> +static int exynos_ppmu_v2_disable(struct devfreq_event_dev *edev)
>> +{
>> +     struct exynos_ppmu *info = devfreq_event_get_drvdata(edev);
>> +     u32 pmnc, clear;
>> +
>> +     /* Disable all counters */
>> +     clear = (PPMU_CCNT_MASK | PPMU_PMCNT0_MASK | PPMU_PMCNT1_MASK
>> +             | PPMU_PMCNT2_MASK | PPMU_PMCNT3_MASK);
>> +
>> +     __raw_writel(clear, info->ppmu.base + PPMUv2_FLAG);
>
> Why aren't you using normal readl()/writel()?  What are the endiannesses
> here?

There are no special reason. Usually I used the __raw_readl/writel to
access the SFR registers

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] PM / devfreq: exynos-ppmu: Add the support of PPMUv2  for Exynos5433 Chanwoo Choi <cwchoi00@gmail.com> - 2015-07-23 16:20 +0200

csiph-web