Groups > linux.kernel > #1190949

Re: [PATCH] mm: rename and document alloc_pages_exact_node

From	Christoph Lameter <cl@linux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: rename and document alloc_pages_exact_node
Date	2015-07-23 16:20 +0200
Message-ID	<pPpvQ-Ga-5@gated-at.bofh.it> (permalink)
References	<pOGfo-1GD-33@gated-at.bofh.it> <pONqy-3CG-19@gated-at.bofh.it> <pP0xr-5zq-3@gated-at.bofh.it> <pPads-3Fl-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 22 Jul 2015, David Rientjes wrote:

> Eek, yeah, that does look bad.  I'm not even sure the
>
> 	if (nid < 0)
> 		nid = numa_node_id();
>
> is correct; I think this should be comparing to NUMA_NO_NODE rather than
> all negative numbers, otherwise we silently ignore overflow and nobody
> ever knows.

Comparing to NUMA_NO_NODE would be better. Also use numa_mem_id() instead
to support memoryless nodes better?

> The only possible downside would be existing users of
> alloc_pages_node() that are calling it with an offline node.  Since it's a
> VM_BUG_ON() that would catch that, I think it should be changed to a
> VM_WARN_ON() and eventually fixed up because it's nonsensical.
> VM_BUG_ON() here should be avoided.

The offline node thing could be addresses by using numa_mem_id()?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mm: rename and document alloc_pages_exact_node Christoph Lameter <cl@linux.com> - 2015-07-23 16:20 +0200

csiph-web