Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct
Date	Tue, 21 Jul 2015 08:30:01 +0200
Message-ID	<pOzdT-bd-9@gated-at.bofh.it> (permalink)
References	<pO7KF-2Os-3@gated-at.bofh.it> <pO7Um-2ZL-15@gated-at.bofh.it>
X-Original-To	Brian Gerst <brgerst@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=xl1U3eJ+48cN0yxSgEra2WAwqRbXDrksIpoISdSCbyY=; b=A+99Wq6KIHLQDWqfPn+q3Qam4Jc3Q0cpT79106Rnr+pvZH0suTwyPcRtI7kZKC1rF2 Ct6jlzOlQIXweAxAN7II8dKV2pn0X4sV02pspJqQFZIw8s1vpdKDpsojO+lZ5IwlmgGQ 10uQUEClwWd74BIP814Vf2/DPHpdmOhmSuV6LFkJ5aHG+vZ/XyEv3QrdCKFLiTk1US0z pyWEwB280tT0+7X+IMi8Kc8+Ixj+gr5yeJ5A9rLopl1jGj+LBOgpQxEdF5luxi63j7+e +dB/HjzvMqHdoi47HR6RS3BdHQOTeR8ahB1IS6o5lUjfp3h2EPvcLL3u2/bXqQWQ8n2c wTSQ==
X-Received	by 10.194.8.40 with SMTP id o8mr64257208wja.100.1437460144571; Mon, 20 Jul 2015 23:29:04 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	20
Organization	linux.* mail to news gateway
X-Original-Cc	x86@kernel.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>, Denys Vlasenko <dvlasenk@redhat.com>, Andy Lutomirski <luto@amacapital.net>, Linus Torvalds <torvalds@linux-foundation.org>
X-Original-Date	Tue, 21 Jul 2015 08:28:58 +0200
X-Original-Message-ID	<20150721062858.GA5110@gmail.com>
X-Original-References	<1437354550-25858-1-git-send-email-brgerst@gmail.com> <1437354550-25858-5-git-send-email-brgerst@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1188695

Show key headers only | View raw

* Brian Gerst <brgerst@gmail.com> wrote:

> Allocate a separate structure for the vm86 fields.

Why is this allocated dynamically? This structure is not very large, and a hole in 
thread_struct isn't that big of an issue - compared to additional fragility 
introduced by the (mostly untested by normal apps) dynamic allocation here ...

I don't mind the introduction of the sub-structure in itself, but please embedd it 
in thread_struct.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Ingo Molnar <mingo@kernel.org> - 2015-07-21 08:30 +0200
  Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Andy Lutomirski <luto@amacapital.net> - 2015-07-21 08:40 +0200
    Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Ingo Molnar <mingo@kernel.org> - 2015-07-21 08:40 +0200
  Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Ingo Molnar <mingo@kernel.org> - 2015-07-21 08:40 +0200

csiph-web