Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct
Date	2015-07-21 08:40 +0200
Message-ID	<pOznA-mJ-13@gated-at.bofh.it> (permalink)
References	<pO7KF-2Os-3@gated-at.bofh.it> <pO7Um-2ZL-15@gated-at.bofh.it> <pOzdT-bd-9@gated-at.bofh.it> <pOznz-mJ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Andy Lutomirski <luto@amacapital.net> wrote:

> On Mon, Jul 20, 2015 at 11:28 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Brian Gerst <brgerst@gmail.com> wrote:
> >
> >> Allocate a separate structure for the vm86 fields.
> >
> > Why is this allocated dynamically? This structure is not very large, and a 
> > hole in thread_struct isn't that big of an issue - compared to additional 
> > fragility introduced by the (mostly untested by normal apps) dynamic 
> > allocation here ...
> >
> > I don't mind the introduction of the sub-structure in itself, but please 
> > embedd it in thread_struct.
> 
> This ends up being several hundred bytes, I think, due to including an entire 
> struct pt_regs.  Do we really want to enlarge thread_struct that much for 
> something that's essentially never used?

Ok, I only judged by the first patch, I did not realize it becomes that much 
larger in later patches.

I've extended the changelog to explain this properly.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Ingo Molnar <mingo@kernel.org> - 2015-07-21 08:30 +0200
  Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Andy Lutomirski <luto@amacapital.net> - 2015-07-21 08:40 +0200
    Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Ingo Molnar <mingo@kernel.org> - 2015-07-21 08:40 +0200
  Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Ingo Molnar <mingo@kernel.org> - 2015-07-21 08:40 +0200

csiph-web