Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct
Date	2015-07-21 08:30 +0200
Message-ID	<pOzdT-bd-9@gated-at.bofh.it> (permalink)
References	<pO7KF-2Os-3@gated-at.bofh.it> <pO7Um-2ZL-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Brian Gerst <brgerst@gmail.com> wrote:

> Allocate a separate structure for the vm86 fields.

Why is this allocated dynamically? This structure is not very large, and a hole in 
thread_struct isn't that big of an issue - compared to additional fragility 
introduced by the (mostly untested by normal apps) dynamic allocation here ...

I don't mind the introduction of the sub-structure in itself, but please embedd it 
in thread_struct.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Ingo Molnar <mingo@kernel.org> - 2015-07-21 08:30 +0200
  Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Andy Lutomirski <luto@amacapital.net> - 2015-07-21 08:40 +0200
    Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Ingo Molnar <mingo@kernel.org> - 2015-07-21 08:40 +0200
  Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Ingo Molnar <mingo@kernel.org> - 2015-07-21 08:40 +0200

csiph-web