Re: [PATCH] mm/rmap: disable preemption for trace_tlb_flush()

From	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/rmap: disable preemption for trace_tlb_flush()
Date	2015-07-17 13:30 +0200
Message-ID	<pNc02-3ZN-7@gated-at.bofh.it> (permalink)
References	<pN7a2-5ys-5@gated-at.bofh.it> <pNbdD-2PM-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (07/17/15 11:39), Mel Gorman wrote:
> On Fri, Jul 17, 2015 at 03:12:54PM +0900, Sergey Senozhatsky wrote:
> > tlb_flush contains TP_CONDITION(cpu_online(smp_processor_id()))
> > which is better be executed with preemption disabled.
> > 
> > Move trace_tlb_flush(TLB_REMOTE_SHOOTDOWN) in try_to_unmap_flush()
> > under get_cpu().
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> 
> Your patch is valid but Sasha also had sent an almost identicial fix a few
> hours ago for identical reasons that Andrew picked up. Thanks for sending
> it in.

Oh, didn't know that. Thanks.

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm/rmap: disable preemption for trace_tlb_flush() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-07-17 08:20 +0200
  Re: [PATCH] mm/rmap: disable preemption for trace_tlb_flush() Mel Gorman <mgorman@suse.de> - 2015-07-17 12:40 +0200
    Re: [PATCH] mm/rmap: disable preemption for trace_tlb_flush() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-07-17 13:30 +0200

csiph-web