Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1186721
| From | Stas Sergeev <stsp@list.ru> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] fixed_phy: handle link-down case |
| Date | 2015-07-17 13:30 +0200 |
| Message-ID | <pNc02-3ZN-5@gated-at.bofh.it> (permalink) |
| References | <pMSE2-1eX-15@gated-at.bofh.it> <pMSNI-1qq-19@gated-at.bofh.it> <pN0Lf-4CQ-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
17.07.2015 02:25, Florian Fainelli пишет: > On 16/07/15 07:50, Stas Sergeev wrote: >> >> Currently fixed_phy driver recognizes only the link-up state. >> This simple patch adds an implementation of link-down state. >> It fixes the status registers when link is down, and also allows >> to register the fixed-phy with link down without specifying the speed. > > This patch still breaks my setups here, e.g: drivers/net/dsa/bcm_sf2.c, > but I will look into it. > > Do we really need this for now for your two other patches to work > properly, or is it just nicer to have? Yes, absolutely. Otherwise registering fixed phy will return -EINVAL because of the missing link speed (even though the link is down). Please, see what makes a problem. I can't reproduce what you report. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 0/3] net: enable inband link state negotiation only when explicitly requested Stas Sergeev <stsp@list.ru> - 2015-07-16 16:50 +0200
[PATCH 3/3] mvneta: use inband status only when explicitly enabled Stas Sergeev <stsp@list.ru> - 2015-07-16 17:00 +0200
[PATCH 1/3] fixed_phy: handle link-down case Stas Sergeev <stsp@list.ru> - 2015-07-16 17:00 +0200
Re: [PATCH 1/3] fixed_phy: handle link-down case Florian Fainelli <f.fainelli@gmail.com> - 2015-07-17 01:30 +0200
Re: [PATCH 1/3] fixed_phy: handle link-down case Stas Sergeev <stsp@list.ru> - 2015-07-17 13:30 +0200
Re: [PATCH 1/3] fixed_phy: handle link-down case Florian Fainelli <f.fainelli@gmail.com> - 2015-07-18 00:10 +0200
Re: [PATCH 1/3] fixed_phy: handle link-down case Stas Sergeev <stsp@list.ru> - 2015-07-18 23:20 +0200
[PATCH 2/3] of_mdio: add new DT property 'managed' to specify the PHY management type Stas Sergeev <stsp@list.ru> - 2015-07-16 17:00 +0200
csiph-web