[PATCH] mm/rmap: disable preemption for trace_tlb_flush()

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] mm/rmap: disable preemption for trace_tlb_flush()
Date	2015-07-17 08:20 +0200
Message-ID	<pN7a2-5ys-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

tlb_flush contains TP_CONDITION(cpu_online(smp_processor_id()))
which is better be executed with preemption disabled.

Move trace_tlb_flush(TLB_REMOTE_SHOOTDOWN) in try_to_unmap_flush()
under get_cpu().

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
 mm/rmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/rmap.c b/mm/rmap.c
index 30812e9..74086cc 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -613,9 +613,9 @@ void try_to_unmap_flush(void)
 	if (!tlb_ubc->flush_required)
 		return;
 
+	cpu = get_cpu();
 	trace_tlb_flush(TLB_REMOTE_SHOOTDOWN, -1UL);
 
-	cpu = get_cpu();
 	if (cpumask_test_cpu(cpu, &tlb_ubc->cpumask))
 		percpu_flush_tlb_batch_pages(&tlb_ubc->cpumask);
 
-- 
2.4.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm/rmap: disable preemption for trace_tlb_flush() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-07-17 08:20 +0200
  Re: [PATCH] mm/rmap: disable preemption for trace_tlb_flush() Mel Gorman <mgorman@suse.de> - 2015-07-17 12:40 +0200
    Re: [PATCH] mm/rmap: disable preemption for trace_tlb_flush() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-07-17 13:30 +0200

csiph-web