Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1184575

[PATCH v2 1/3] drivers/xen/preempt: use need_resched() instead of should_resched()

Show all headers | View raw

This code is used only when CONFIG_PREEMPT=n and only in non-atomic context:
xen_in_preemptible_hcall is set only in privcmd_ioctl_hypercall().
Thus preempt_count is zero and should_resched() is equal to need_resched().

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
---
 drivers/xen/preempt.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/preempt.c b/drivers/xen/preempt.c
index a1800c150839..08cb419eb4e6 100644
--- a/drivers/xen/preempt.c
+++ b/drivers/xen/preempt.c
@@ -31,7 +31,7 @@ EXPORT_SYMBOL_GPL(xen_in_preemptible_hcall);
 asmlinkage __visible void xen_maybe_preempt_hcall(void)
 {
 	if (unlikely(__this_cpu_read(xen_in_preemptible_hcall)
-		     && should_resched())) {
+		     && need_resched())) {
 		/*
 		 * Clear flag as we may be rescheduled on a different
 		 * cpu.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/3] drivers/xen/preempt: use need_resched() instead of  should_resched() Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2015-07-15 12:00 +0200
  [PATCH v2 2/3] KVM: PPC: Book3S HV: Use need_resched() instead of  should_resched() Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2015-07-15 12:00 +0200
  [PATCH v2 3/3] sched/preempt: fix cond_resched_lock() and  cond_resched_softirq() Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2015-07-15 12:00 +0200
    Re: [PATCH v2 3/3] sched/preempt: fix cond_resched_lock() and  cond_resched_softirq() Eric Dumazet <eric.dumazet@gmail.com> - 2015-07-15 14:20 +0200
      Re: [PATCH v2 3/3] sched/preempt: fix cond_resched_lock() and cond_resched_softirq() Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2015-07-15 15:00 +0200
        Re: [PATCH v2 3/3] sched/preempt: fix cond_resched_lock() and  cond_resched_softirq() Peter Zijlstra <peterz@infradead.org> - 2015-07-15 15:40 +0200
  Re: [Xen-devel] [PATCH v2 1/3] drivers/xen/preempt: use need_resched()  instead of should_resched() David Vrabel <david.vrabel@citrix.com> - 2015-07-20 15:50 +0200

csiph-web