Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1184606

[PATCH v2 2/3] KVM: PPC: Book3S HV: Use need_resched() instead of should_resched()

Show all headers | View raw

Function should_resched() is equal to (!preempt_count() && need_resched()).
In preemptive kernel preempt_count here is non-zero because of vc->lock.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
---
 arch/powerpc/kvm/book3s_hv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
index 68d067ad4222..a9f753fb73a8 100644
--- a/arch/powerpc/kvm/book3s_hv.c
+++ b/arch/powerpc/kvm/book3s_hv.c
@@ -2178,7 +2178,7 @@ static int kvmppc_run_vcpu(struct kvm_run *kvm_run, struct kvm_vcpu *vcpu)
 		vc->runner = vcpu;
 		if (n_ceded == vc->n_runnable) {
 			kvmppc_vcore_blocked(vc);
-		} else if (should_resched()) {
+		} else if (need_resched()) {
 			vc->vcore_state = VCORE_PREEMPT;
 			/* Let something else run */
 			cond_resched_lock(&vc->lock);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/3] drivers/xen/preempt: use need_resched() instead of  should_resched() Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2015-07-15 12:00 +0200
  [PATCH v2 2/3] KVM: PPC: Book3S HV: Use need_resched() instead of  should_resched() Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2015-07-15 12:00 +0200
  [PATCH v2 3/3] sched/preempt: fix cond_resched_lock() and  cond_resched_softirq() Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2015-07-15 12:00 +0200
    Re: [PATCH v2 3/3] sched/preempt: fix cond_resched_lock() and  cond_resched_softirq() Eric Dumazet <eric.dumazet@gmail.com> - 2015-07-15 14:20 +0200
      Re: [PATCH v2 3/3] sched/preempt: fix cond_resched_lock() and cond_resched_softirq() Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2015-07-15 15:00 +0200
        Re: [PATCH v2 3/3] sched/preempt: fix cond_resched_lock() and  cond_resched_softirq() Peter Zijlstra <peterz@infradead.org> - 2015-07-15 15:40 +0200
  Re: [Xen-devel] [PATCH v2 1/3] drivers/xen/preempt: use need_resched()  instead of should_resched() David Vrabel <david.vrabel@citrix.com> - 2015-07-20 15:50 +0200

csiph-web