Re: [RFC Patch V1 04/12] s390/pci: Use for_pci_msi_entry() to access MSI device list

From	Sebastian Ott <sebott@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [RFC Patch V1 04/12] s390/pci: Use for_pci_msi_entry() to access MSI device list
Date	2015-07-13 14:50 +0200
Message-ID	<pLLlh-53X-25@gated-at.bofh.it> (permalink)
References	<pKeUq-5Qy-3@gated-at.bofh.it> <pKf47-69s-53@gated-at.bofh.it>
Organization	"IBM Deutschland Research & Development GmbH / Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294"

Show all headers | View raw

On Thu, 9 Jul 2015, Jiang Liu wrote:

> Use accessor for_pci_msi_entry() to access MSI device list, so we could
> easily move msi_list from struct pci_dev into struct device later.
> 
> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>

Acked-by: Sebastian Ott <sebott@linux.vnet.ibm.com>

Regards,
Sebastian

> ---
>  arch/s390/pci/pci.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c
> index 598f023cf8a6..34f162753403 100644
> --- a/arch/s390/pci/pci.c
> +++ b/arch/s390/pci/pci.c
> @@ -414,7 +414,7 @@ int arch_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
> 
>  	/* Request MSI interrupts */
>  	hwirq = 0;
> -	list_for_each_entry(msi, &pdev->msi_list, list) {
> +	for_each_pci_msi_entry(msi, pdev) {
>  		rc = -EIO;
>  		irq = irq_alloc_desc(0);	/* Alloc irq on node 0 */
>  		if (irq < 0)
> @@ -440,7 +440,7 @@ int arch_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
>  	return (msi_vecs == nvec) ? 0 : msi_vecs;
> 
>  out_msi:
> -	list_for_each_entry(msi, &pdev->msi_list, list) {
> +	for_each_pci_msi_entry(msi, pdev) {
>  		if (hwirq-- == 0)
>  			break;
>  		irq_set_msi_desc(msi->irq, NULL);
> @@ -470,7 +470,7 @@ void arch_teardown_msi_irqs(struct pci_dev *pdev)
>  		return;
> 
>  	/* Release MSI interrupts */
> -	list_for_each_entry(msi, &pdev->msi_list, list) {
> +	for_each_pci_msi_entry(msi, pdev) {
>  		if (msi->msi_attrib.is_msix)
>  			__pci_msix_desc_mask_irq(msi, 1);
>  		else
> -- 
> 1.7.10.4
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[RFC Patch V1 00/12] Reorganize struct msi_desc to prepare for support of generic MSI Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:00 +0200
  [RFC Patch V1 03/12] PowerPC, PCI: Use for_pci_msi_entry() to access MSI device list Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:00 +0200
  [RFC Patch V1 05/12] x86, PCI: Use for_pci_msi_entry() to access MSI device list Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
  [RFC Patch V1 09/12] genirq: Move msi_list from struct pci_dev to struct device Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
    Re: [RFC Patch V1 09/12] genirq: Move msi_list from struct pci_dev  to struct device Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-07-10 02:30 +0200
  [RFC Patch V1 06/12] PCI: Use for_pci_msi_entry() to access MSI device list Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
  Re: [RFC Patch V1 07/12] sparc, PCI: Use helper functions to  access fields in struct msi_desc David Miller <davem@davemloft.net> - 2015-07-09 10:10 +0200
  [RFC Patch V1 12/12] genirq, PCI: Move alloc_msi_entry() from PCI MSI code into generic MSI code Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
  [RFC Patch V1 10/12] genirq, PCI: Store 'struct device *' instead 'struct pci_dev *' in struct msi_desc Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
  [RFC Patch V1 11/12] genirq, PCI: Reorginize struct msi_desc to prepare for support of generic MSI Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
  [RFC Patch V1 08/12] PCI: Use helper functions to access fields in struct msi_desc Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
  [RFC Patch V1 07/12] sparc, PCI: Use helper functions to access fields in struct msi_desc Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
  [RFC Patch V1 04/12] s390/pci: Use for_pci_msi_entry() to access MSI device list Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
    Re: [RFC Patch V1 04/12] s390/pci: Use for_pci_msi_entry() to access  MSI device list Sebastian Ott <sebott@linux.vnet.ibm.com> - 2015-07-13 14:50 +0200
  Re: [RFC Patch V1 00/12] Reorganize struct msi_desc to prepare for  support of generic MSI Yijing Wang <wangyijing@huawei.com> - 2015-07-10 03:50 +0200

csiph-web