Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1180507

[RFC Patch V1 05/12] x86, PCI: Use for_pci_msi_entry() to access MSI device list

Show all headers | View raw

Use accessor for_pci_msi_entry() to access MSI device list, so we could
easily move msi_list from struct pci_dev into struct device later.

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
 arch/x86/pci/xen.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
index d22f4b5bbc04..ff31ab464213 100644
--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -179,7 +179,7 @@ static int xen_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
 	if (ret)
 		goto error;
 	i = 0;
-	list_for_each_entry(msidesc, &dev->msi_list, list) {
+	for_each_pci_msi_entry(msidesc, dev) {
 		irq = xen_bind_pirq_msi_to_irq(dev, msidesc, v[i],
 					       (type == PCI_CAP_ID_MSI) ? nvec : 1,
 					       (type == PCI_CAP_ID_MSIX) ?
@@ -230,7 +230,7 @@ static int xen_hvm_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
 	if (type == PCI_CAP_ID_MSI && nvec > 1)
 		return 1;
 
-	list_for_each_entry(msidesc, &dev->msi_list, list) {
+	for_each_pci_msi_entry(msidesc, dev) {
 		__pci_read_msi_msg(msidesc, &msg);
 		pirq = MSI_ADDR_EXT_DEST_ID(msg.address_hi) |
 			((msg.address_lo >> MSI_ADDR_DEST_ID_SHIFT) & 0xff);
@@ -274,7 +274,7 @@ static int xen_initdom_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
 	int ret = 0;
 	struct msi_desc *msidesc;
 
-	list_for_each_entry(msidesc, &dev->msi_list, list) {
+	for_each_pci_msi_entry(msidesc, dev) {
 		struct physdev_map_pirq map_irq;
 		domid_t domid;
 
@@ -386,7 +386,7 @@ static void xen_teardown_msi_irqs(struct pci_dev *dev)
 {
 	struct msi_desc *msidesc;
 
-	msidesc = list_entry(dev->msi_list.next, struct msi_desc, list);
+	msidesc = first_pci_msi_entry(dev);
 	if (msidesc->msi_attrib.is_msix)
 		xen_pci_frontend_disable_msix(dev);
 	else
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC Patch V1 00/12] Reorganize struct msi_desc to prepare for support of generic MSI Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:00 +0200
  [RFC Patch V1 03/12] PowerPC, PCI: Use for_pci_msi_entry() to access MSI device list Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:00 +0200
  [RFC Patch V1 05/12] x86, PCI: Use for_pci_msi_entry() to access MSI device list Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
  [RFC Patch V1 09/12] genirq: Move msi_list from struct pci_dev to struct device Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
    Re: [RFC Patch V1 09/12] genirq: Move msi_list from struct pci_dev  to struct device Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-07-10 02:30 +0200
  [RFC Patch V1 06/12] PCI: Use for_pci_msi_entry() to access MSI device list Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
  Re: [RFC Patch V1 07/12] sparc, PCI: Use helper functions to  access fields in struct msi_desc David Miller <davem@davemloft.net> - 2015-07-09 10:10 +0200
  [RFC Patch V1 12/12] genirq, PCI: Move alloc_msi_entry() from PCI MSI code into generic MSI code Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
  [RFC Patch V1 10/12] genirq, PCI: Store 'struct device *' instead 'struct pci_dev *' in struct msi_desc Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
  [RFC Patch V1 11/12] genirq, PCI: Reorginize struct msi_desc to prepare for support of generic MSI Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
  [RFC Patch V1 08/12] PCI: Use helper functions to access fields in struct msi_desc Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
  [RFC Patch V1 07/12] sparc, PCI: Use helper functions to access fields in struct msi_desc Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
  [RFC Patch V1 04/12] s390/pci: Use for_pci_msi_entry() to access MSI device list Jiang Liu <jiang.liu@linux.intel.com> - 2015-07-09 10:10 +0200
    Re: [RFC Patch V1 04/12] s390/pci: Use for_pci_msi_entry() to access  MSI device list Sebastian Ott <sebott@linux.vnet.ibm.com> - 2015-07-13 14:50 +0200
  Re: [RFC Patch V1 00/12] Reorganize struct msi_desc to prepare for  support of generic MSI Yijing Wang <wangyijing@huawei.com> - 2015-07-10 03:50 +0200

csiph-web