Re: [PATCH] leds: Allow compile test of LEDS_AAT1290 and LEDS_KTD2692 if !GPIOLIB

From	Jacek Anaszewski <j.anaszewski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] leds: Allow compile test of LEDS_AAT1290 and LEDS_KTD2692 if !GPIOLIB
Date	2015-07-13 14:50 +0200
Message-ID	<pLLlg-53X-23@gated-at.bofh.it> (permalink)
References	<pJeWx-DK-63@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Geert,

Thanks for the patch.

On 07/06/2015 03:42 PM, Geert Uytterhoeven wrote:
> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
> functionality only, can still be compiled if GPIOLIB is not enabled.
>
> If COMPILE_TEST is enabled, relax the dependency on GPIOLIB for the
> recently introduced symbols LEDS_AAT1290 and LEDS_KTD2692.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>   drivers/leds/Kconfig | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 94eced66d877182b..cf0248b8dbb9c023 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -43,7 +43,7 @@ config LEDS_AAT1290
>   	tristate "LED support for the AAT1290"
>   	depends on LEDS_CLASS_FLASH
>   	depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> -	depends on GPIOLIB
> +	depends on GPIOLIB || COMPILE_TEST
>   	depends on OF
>   	depends on PINCTRL
>   	help
> @@ -543,7 +543,8 @@ config LEDS_MENF21BMC
>
>   config LEDS_KTD2692
>   	tristate "LED support for KTD2692 flash LED controller"
> -	depends on LEDS_CLASS_FLASH && GPIOLIB && OF
> +	depends on LEDS_CLASS_FLASH && OF
> +	depends on GPIOLIB || COMPILE_TEST
>   	help
>   	  This option enables support for KTD2692 LED flash connected
>   	  through ExpressWire interface.
>

Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] leds: Allow compile test of LEDS_AAT1290 and LEDS_KTD2692  if !GPIOLIB Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-07-13 14:50 +0200

csiph-web