Re: [PATCH 0/2] mm/shrinker: make unregister_shrinker() less fragile

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/2] mm/shrinker: make unregister_shrinker() less fragile
Date	2015-07-13 11:10 +0200
Message-ID	<pLHUn-3aG-19@gated-at.bofh.it> (permalink)
References	<pKWC6-8du-13@gated-at.bofh.it> <pKZTj-1Tn-11@gated-at.bofh.it> <pLfv3-2G0-1@gated-at.bofh.it> <pLFzb-1F6-7@gated-at.bofh.it> <pLFSy-1Lw-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 13, 2015 at 03:52:53PM +0900, Sergey Senozhatsky wrote:
> Why? In some sense, shrinker callbacks are just a way to be nice.
> No one writes a driver just to be able to handle shrinker calls. An
> ability to react to those calls is just additional option; it does
> not directly affect or limit driver's functionality (at least, it
> really should not).

No, they are not just nice.  They are a fundamental part of memory
management and required to reclaim (often large) amounts of memory.

Nevermind that we don't ignore any other registration time error in
the kernel.

> > The right way forward is to handle register failure properly.
> 
> In other words, to
>  (a) keep a flag to signify that register was not successful
> or
>  (b) look at ->shrinker.list.next or ->nr_deferred
> or
>  (c) treat register failures as critical errors. (I sort of
>      disagree with you here).

The only important part is here is (c).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 0/2] mm/shrinker: make unregister_shrinker() less fragile Christoph Hellwig <hch@infradead.org> - 2015-07-11 12:10 +0200
  Re: [PATCH 0/2] mm/shrinker: make unregister_shrinker() less fragile Christoph Hellwig <hch@infradead.org> - 2015-07-13 08:40 +0200
    Re: [PATCH 0/2] mm/shrinker: make unregister_shrinker() less fragile Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-07-13 09:00 +0200
      Re: [PATCH 0/2] mm/shrinker: make unregister_shrinker() less fragile Christoph Hellwig <hch@infradead.org> - 2015-07-13 11:10 +0200
        Re: [PATCH 0/2] mm/shrinker: make unregister_shrinker() less fragile Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-07-13 11:40 +0200

csiph-web