Re: [PATCH v2 3/9] arm: twr-k70f120m: clock driver for Kinetis SoC

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/9] arm: twr-k70f120m: clock driver for Kinetis SoC
Date	Thu, 02 Jul 2015 14:50:02 +0200
Message-ID	<pHM6e-2Kb-29@gated-at.bofh.it> (permalink)
References	<pH2Zr-1ZE-15@gated-at.bofh.it> <pHsKe-7lQ-15@gated-at.bofh.it> <pHJL3-1mP-3@gated-at.bofh.it>
X-Original-To	Paul Osmialowski <pawelo@king.net.pl>
User-Agent	KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
X-Provags-ID	V03:K0:LrB0RRhlcRuyfJGqZ+Q9Ap8KJLf2WuDGwWeHJ72vnj4PO9i73Jw R+NVBtOl952VPNFUu0FjCETNGsY0mSp7Zwf9tTv+4DnpCvyDH9VsD0ZNzzo/L0Qs+7t9Ddm /utBe7hDaG82r0IqoGI7V3LOZW8tSF4edKQXvTnCNUS7PsV0gXvCaorJWtQVHBaNsIudikS SBplAXc+NAmiGgkAHFz4g==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:ltXU+QToXmA=:lyOOnOHbW4PW8pdB+eaqgZ uYjUEBRFq1kEEetwyPE7rlsoNN8KVX4Vm83UudpyPkBHdtNaM4ixVPtuCEFzhOQ9kO7ysb6w9 XPuiEJF9MYNJmQT131MSkzD58hVpphxTk1nukl3Je8zZpSG/wzNiSoxT9KRMGVGbSBM9+Fk9B SL3o5KzYlJMLFgJ2mEG76jOenAP2y5JzUI4qFRmufeQCdOjrZ6qZJAqwO4IyclWtcBcVhghL7 P1nURhSuku8fLC0jEqKMXzFg7IDVICMxoEnWRmI0tvG08uI1I/ZvvbmJ55V0X3A78J/HloxwK fXvk1nHr2k9Jx11dI+uV5Odah26tBs6n0oxNI9au/gVbJUrjYDq31ik9zbI5jC49hJA9epeMc VFfYR0h1UShmB7c1o2GSQXZnGfMBhsDz/zzvvSsHdwK1ba9yeWt0kccMtT3ogvPGuFl4AJTtj haAoCi7bU8ZT82BrAmlkSqTuYZvHgokoHAfSU8JY9EdFEtPpaaNJDEZ1vOqYaFyiNXJFrNZJn cMkIGgmYdjs4q4FxuXnLm9yhR+CKJvxZoBOc6W7fp+cmIApwxBL1uZtaCb0TSD4uUNMhDFSDn iiyuRPValMTGO9tmLZrusejAMxksqyWi8WDY+PlIM1h7tLfUc1hT4uP+nsVSZgauLJqiSn1ra UNxRFQNmk7yneg1HUv3w3la82Rco1U6PajboQV028hkKOwQ==
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Jiri Slaby <jslaby@suse.cz>, Kumar Gala <galak@codeaurora.org>, Linus Walleij <linus.walleij@linaro.org>, Mark Rutland <mark.rutland@arm.com>, Michael Turquette <mturquette@baylibre.com>, Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>, Russell King <linux@arm.linux.org.uk>, Stephen Boyd <sboyd@codeaurora.org>, Vinod Koul <vinod.koul@intel.com>, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Nicolas Pitre <nicolas.pitre@linaro.org>, Sergei Poselenov <sposelenov@emcraft.com>, Paul Bolle <pebolle@tiscali.nl>, Jingchang Lu <jingchang.lu@freescale.com>, Yuri Tikhonov <yur@emcraft.com>, Rob Herring <r.herring@freescale.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>, Alexander Potashev <aspotashev@emcraft.com>, Frank Li <Frank.Li@freescale.com>, Thomas Gleixner <tglx@linutronix.de>, Anson Huang <b20788@freescale.com>
X-Original-Date	Thu, 02 Jul 2015 14:40:23 +0200
X-Original-Message-ID	<1861313.aMcV1xHCIq@wuerfel>
X-Original-References	<1435667250-28299-1-git-send-email-pawelo@king.net.pl> <alpine.LNX.2.00.1507011756140.14440@localhost.localdomain> <alpine.LNX.2.00.1507021206410.13210@localhost.localdomain>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1175949

Show key headers only | View raw

On Thursday 02 July 2015 12:08:39 Paul Osmialowski wrote:
> Nah, I've found this code hard to maintain. I'm attaching simplified 
> version.
> 

Looks better to me, but of course needs full review from the clock
maintainers.

I wonder if you could move out the fixed rate clocks into their own
nodes. Are they actually controlled by the same block? If they are
just fixed, you can use the normal binding for fixed rate clocks
and only describe the clocks that are related to the driver.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 3/9] arm: twr-k70f120m: clock driver for Kinetis SoC Arnd Bergmann <arnd@arndb.de> - 2015-06-30 22:40 +0200
  Re: [PATCH v2 3/9] arm: twr-k70f120m: clock driver for Kinetis SoC Paul Osmialowski <pawelo@king.net.pl> - 2015-07-02 12:20 +0200
    Re: [PATCH v2 3/9] arm: twr-k70f120m: clock driver for Kinetis SoC Arnd Bergmann <arnd@arndb.de> - 2015-07-02 14:50 +0200

csiph-web