Re: [PATCH v2 3/9] arm: twr-k70f120m: clock driver for Kinetis SoC

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/9] arm: twr-k70f120m: clock driver for Kinetis SoC
Date	2015-07-02 14:50 +0200
Message-ID	<pHM6e-2Kb-29@gated-at.bofh.it> (permalink)
References	<pH2Zr-1ZE-15@gated-at.bofh.it> <pHsKe-7lQ-15@gated-at.bofh.it> <pHJL3-1mP-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday 02 July 2015 12:08:39 Paul Osmialowski wrote:
> Nah, I've found this code hard to maintain. I'm attaching simplified 
> version.
> 

Looks better to me, but of course needs full review from the clock
maintainers.

I wonder if you could move out the fixed rate clocks into their own
nodes. Are they actually controlled by the same block? If they are
just fixed, you can use the normal binding for fixed rate clocks
and only describe the clocks that are related to the driver.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 3/9] arm: twr-k70f120m: clock driver for Kinetis SoC Arnd Bergmann <arnd@arndb.de> - 2015-06-30 22:40 +0200
  Re: [PATCH v2 3/9] arm: twr-k70f120m: clock driver for Kinetis SoC Paul Osmialowski <pawelo@king.net.pl> - 2015-07-02 12:20 +0200
    Re: [PATCH v2 3/9] arm: twr-k70f120m: clock driver for Kinetis SoC Arnd Bergmann <arnd@arndb.de> - 2015-07-02 14:50 +0200

csiph-web