Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1175948

RE: [f2fs-dev] [PATCH 2/2] f2fs: shrink unreferenced extent_caches first

Show all headers | View raw

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Wednesday, July 01, 2015 9:26 AM
> To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org;
> linux-fsdevel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net
> Cc: Jaegeuk Kim; Jaegeuk Kim
> Subject: [f2fs-dev] [PATCH 2/2] f2fs: shrink unreferenced extent_caches first
> 
> If an extent_tree entry has a zero reference count, we can drop it from the
> cache in higher priority rather than currently referencing entries.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  fs/f2fs/data.c | 51 +++++++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 41 insertions(+), 10 deletions(-)
> 
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 8f059e0..a0a0e2b 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -661,21 +661,54 @@ unsigned int f2fs_shrink_extent_tree(struct f2fs_sb_info *sbi, int
> nr_shrink)
>  	struct radix_tree_root *root = &sbi->extent_tree_root;
>  	unsigned int found;
>  	unsigned int node_cnt = 0, tree_cnt = 0;
> +	int remained;
> 
>  	if (!test_opt(sbi, EXTENT_CACHE))
>  		return 0;
> 
> +	if (!down_write_trylock(&sbi->extent_tree_lock))
> +		goto out;
> +
> +	/* 1. remove unreferenced extent tree */

We always release extent node and tree from inode with lowest ino,
why not random ino?

And this step releasing breaks the rule of lru runs.

Some unreferenced file has high hit ratio and some referenced file may
have low hit ratio. Why not release low hit ratio extent tree at first?

Thanks,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] f2fs: check the largest extent at look-up time Jaegeuk Kim <jaegeuk@kernel.org> - 2015-07-01 03:30 +0200
  [PATCH 2/2] f2fs: shrink unreferenced extent_caches first Jaegeuk Kim <jaegeuk@kernel.org> - 2015-07-01 03:30 +0200
    RE: [f2fs-dev] [PATCH 2/2] f2fs: shrink unreferenced extent_caches first Chao Yu <yuchaochina@hotmail.com> - 2015-07-02 14:50 +0200
      Re: [f2fs-dev] [PATCH 2/2] f2fs: shrink unreferenced extent_caches  first Jaegeuk Kim <jaegeuk@kernel.org> - 2015-07-04 08:30 +0200
        Re: [f2fs-dev] [PATCH 2/2] f2fs: shrink unreferenced extent_caches  first Jaegeuk Kim <jaegeuk@kernel.org> - 2015-07-07 00:20 +0200
  RE: [f2fs-dev] [PATCH 1/2] f2fs: check the largest extent at look-up time Chao Yu <yuchaochina@hotmail.com> - 2015-07-02 14:40 +0200

csiph-web