Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified
Date	Thu, 18 Jun 2015 21:30:01 +0200
Message-ID	<pCNFD-10E-3@gated-at.bofh.it> (permalink)
References	<pCNFD-10E-5@gated-at.bofh.it>
X-Original-To	Lukas Wunner <lukas@wunner.de>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.26
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	48
Organization	linux.* mail to news gateway
X-Original-Cc	Jiri Olsa <jolsa@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 18 Jun 2015 21:29:32 +0200
X-Original-Message-ID	<20150618192931.GA11223@krava.redhat.com>
X-Original-References	<201506181332.t5IDWuUq027242@int-mx13.intmail.prod.int.phx2.redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1168237

Show key headers only | View raw

On Thu, Jun 18, 2015 at 01:00:32PM +0200, Lukas Wunner wrote:
> Invoking Makefile.perf with prefix= breaks the build since Makefile.perf
> hands that variable down to Makefile.build where it overrides
>     prefix       := $(subst ./,,$(OUTPUT)$(dir)/)
> 
> leading to errors like this:
>     No rule to make target '/usrabspath.o', needed by '/usrlibperf-in.o'

hum, what specific make command is failing?

jirka

> 
> Fixes: c819e2cf2eb6f65d3208d195d7a0edef6108d5
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> ---
>  tools/build/Makefile.build | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> index 10df572..98cfc38 100644
> --- a/tools/build/Makefile.build
> +++ b/tools/build/Makefile.build
> @@ -94,12 +94,12 @@ obj-y        := $(patsubst %/, %/$(obj)-in.o, $(obj-y))
>  subdir-obj-y := $(filter %/$(obj)-in.o, $(obj-y))
>  
>  # '$(OUTPUT)/dir' prefix to all objects
> -prefix       := $(subst ./,,$(OUTPUT)$(dir)/)
> -obj-y        := $(addprefix $(prefix),$(obj-y))
> -subdir-obj-y := $(addprefix $(prefix),$(subdir-obj-y))
> +objprefix    := $(subst ./,,$(OUTPUT)$(dir)/)
> +obj-y        := $(addprefix $(objprefix),$(obj-y))
> +subdir-obj-y := $(addprefix $(objprefix),$(subdir-obj-y))
>  
>  # Final '$(obj)-in.o' object
> -in-target := $(prefix)$(obj)-in.o
> +in-target := $(objprefix)$(obj)-in.o
>  
>  PHONY += $(subdir-y)
>  
> -- 
> 1.8.5.2 (Apple Git-48)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if  prefix= is specified Jiri Olsa <jolsa@redhat.com> - 2015-06-18 21:30 +0200
  Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if  prefix= is specified Lukas Wunner <lukas@wunner.de> - 2015-06-18 22:10 +0200
    Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage  if prefix= is specified David Ahern <dsahern@gmail.com> - 2015-06-18 22:30 +0200
      Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if  prefix= is specified Lukas Wunner <lukas@wunner.de> - 2015-06-18 22:50 +0200

csiph-web