Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors
Date	Thu, 18 Jun 2015 09:00:01 +0200
Message-ID	<pCBXP-Or-1@gated-at.bofh.it> (permalink)
References	<pBfPH-5df-3@gated-at.bofh.it> <pBfZo-5p1-33@gated-at.bofh.it> <pBxWh-6jv-15@gated-at.bofh.it> <pBPzP-6HF-7@gated-at.bofh.it> <pCzW2-6qb-9@gated-at.bofh.it>
X-Original-To	Finn Thain <fthain@telegraphics.com.au>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=l6nc/uJtDEXcdLqCJ9izs2IL/O9XXZp2HH7a1zzhX1A=; b=TVbaM48zdxlzSwdO+XTgUXukhyACFc5E8Z5yi0KqPcFHvK9hl+dojXVakD6lFwOUCZ tRVw0k6JCyq1XK8efiSEFBzzRbs+P3laK0pG9pFGE1YJFqrxcYeRZIVzH8bbh17rAx+c J8Ryq8AlZPP9xuO78n1UjfrjonJlPs1Mj8ViAeatbxuJI0RSakcIa73Cu178jeUcILWe UAQily0smdZBi2JlPiuJW4Y3fzsPQXj00Ukijikbmb3juVuEFDbKfJmILQ8ngdqXaUfk rkmX34vBgzLymB0VZPuipKQAoY8K5vGhfrzAB5Wq0DmwvlZ7Bf+Dnmj+5miZdU1A3E+I +t9A==
MIME-Version	1.0
X-Received	by 10.202.90.133 with SMTP id o127mr7370672oib.79.1434610764185; Wed, 17 Jun 2015 23:59:24 -0700 (PDT)
X-Google-Sender-Auth	xiP7ZDyAaZ-SwE08NgKBJ0ddzKg
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Linux/m68k" <linux-m68k@vger.kernel.org>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, "linux-api@vger.kernel.org" <linux-api@vger.kernel.org>
X-Original-Date	Thu, 18 Jun 2015 08:59:24 +0200
X-Original-Message-ID	<CAMuHMdX9BaBj4gFW4aP_t_GFsPQi_wU8-sQsUFr_A0cksr4MJQ@mail.gmail.com>
X-Original-References	<20150614074607.242676098@telegraphics.com.au> <20150614074613.054681242@telegraphics.com.au> <CAMuHMdWzKvWjAE3u54E4xewEDX+zJqEDEvRmO2twpeD2vmBzog@mail.gmail.com> <alpine.LNX.2.00.1506152213340.12762@nippy.intranet> <alpine.LNX.2.00.1506181417260.30499@nippy.intranet>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1167604

Show key headers only | View raw

Hi Finn,

On Thu, Jun 18, 2015 at 6:49 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
> On Tue, 16 Jun 2015, in which I wrote:
>> On Mon, 15 Jun 2015, Geert Uytterhoeven wrote:
>> > More magic values...
>>
>> [...] The only useful RTC documentation I've ever come across is this:
>> http://mac.linux-m68k.org/devel/plushw.php
>
> This document appears to be Inside Macintosh vol. III ch. 2. It describes
> the early RTC chip that lacks two-byte operations and XPRAM, and pre-dates
> all Mac hardware supported in mainline Linux. But it does offer some
> useful data, though not enough to answer all of your criticisms (as I
> said).

I understand.

>> [...] I think they should be applied across the entire file, and in a
>> different patch. Inconsistent use of such macros would be undesirable
>> IMHO.
>
> So, unless you have other ideas, I will revise this patch and insert an
> earlier patch to address existing code, and codify what little reliable
> chip data we have.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors Geert Uytterhoeven <geert@linux-m68k.org> - 2015-06-15 10:30 +0200
  Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors Finn Thain <fthain@telegraphics.com.au> - 2015-06-18 06:50 +0200
    Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors Geert Uytterhoeven <geert@linux-m68k.org> - 2015-06-18 09:00 +0200

csiph-web