Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors
Date	2015-06-18 09:00 +0200
Message-ID	<pCBXP-Or-1@gated-at.bofh.it> (permalink)
References	<pBfPH-5df-3@gated-at.bofh.it> <pBfZo-5p1-33@gated-at.bofh.it> <pBxWh-6jv-15@gated-at.bofh.it> <pBPzP-6HF-7@gated-at.bofh.it> <pCzW2-6qb-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Finn,

On Thu, Jun 18, 2015 at 6:49 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
> On Tue, 16 Jun 2015, in which I wrote:
>> On Mon, 15 Jun 2015, Geert Uytterhoeven wrote:
>> > More magic values...
>>
>> [...] The only useful RTC documentation I've ever come across is this:
>> http://mac.linux-m68k.org/devel/plushw.php
>
> This document appears to be Inside Macintosh vol. III ch. 2. It describes
> the early RTC chip that lacks two-byte operations and XPRAM, and pre-dates
> all Mac hardware supported in mainline Linux. But it does offer some
> useful data, though not enough to answer all of your criticisms (as I
> said).

I understand.

>> [...] I think they should be applied across the entire file, and in a
>> different patch. Inconsistent use of such macros would be undesirable
>> IMHO.
>
> So, unless you have other ideas, I will revise this patch and insert an
> earlier patch to address existing code, and codify what little reliable
> chip data we have.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors Geert Uytterhoeven <geert@linux-m68k.org> - 2015-06-15 10:30 +0200
  Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors Finn Thain <fthain@telegraphics.com.au> - 2015-06-18 06:50 +0200
    Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors Geert Uytterhoeven <geert@linux-m68k.org> - 2015-06-18 09:00 +0200

csiph-web