Re: [PATCH] ARM: orion5x: Use vsprintf %pM extension

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Andrew Lunn <andrew@lunn.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: orion5x: Use vsprintf %pM extension
Date	Mon, 15 Jun 2015 05:40:01 +0200
Message-ID	<pBtpD-8eb-7@gated-at.bofh.it> (permalink)
References	<pBs0x-6b3-11@gated-at.bofh.it>
X-Original-To	Joe Perches <joe@perches.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	51
Organization	linux.* mail to news gateway
X-Original-Cc	Jason Cooper <jason@lakedaemon.net>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Gregory Clement <gregory.clement@free-electrons.com>, Russell King <linux@arm.linux.org.uk>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 15 Jun 2015 05:28:42 +0200
X-Original-Message-ID	<20150615032842.GD10886@lunn.ch>
X-Original-References	<1434333690.2507.30.camel@perches.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1165004

Show key headers only | View raw

On Sun, Jun 14, 2015 at 07:01:30PM -0700, Joe Perches wrote:
> Format mac addresses with the normal kernel extension.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Acked-by: Andrew Lunn <andrew@lunn.ch>

	  Andrew

> ---
>  arch/arm/mach-orion5x/dns323-setup.c | 4 +---
>  arch/arm/mach-orion5x/tsx09-common.c | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/mach-orion5x/dns323-setup.c b/arch/arm/mach-orion5x/dns323-setup.c
> index 09d2a26..f267e58 100644
> --- a/arch/arm/mach-orion5x/dns323-setup.c
> +++ b/arch/arm/mach-orion5x/dns323-setup.c
> @@ -236,9 +236,7 @@ static int __init dns323_read_mac_addr(void)
>  	}
>  
>  	iounmap(mac_page);
> -	printk("DNS-323: Found ethernet MAC address: ");
> -	for (i = 0; i < 6; i++)
> -		printk("%.2x%s", addr[i], (i < 5) ? ":" : ".\n");
> +	printk("DNS-323: Found ethernet MAC address: %pM\n", addr);
>  
>  	memcpy(dns323_eth_data.mac_addr, addr, 6);
>  
> diff --git a/arch/arm/mach-orion5x/tsx09-common.c b/arch/arm/mach-orion5x/tsx09-common.c
> index 7189827..24b2959 100644
> --- a/arch/arm/mach-orion5x/tsx09-common.c
> +++ b/arch/arm/mach-orion5x/tsx09-common.c
> @@ -101,9 +101,7 @@ static int __init qnap_tsx09_check_mac_addr(const char *addr_str)
>  		addr[i] = byte;
>  	}
>  
> -	printk(KERN_INFO "tsx09: found ethernet mac address ");
> -	for (i = 0; i < 6; i++)
> -		printk("%.2x%s", addr[i], (i < 5) ? ":" : ".\n");
> +	printk(KERN_INFO "tsx09: found ethernet mac address %pM\n", addr);
>  
>  	memcpy(qnap_tsx09_eth_data.mac_addr, addr, 6);
>  
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] ARM: orion5x: Use vsprintf %pM extension Andrew Lunn <andrew@lunn.ch> - 2015-06-15 05:40 +0200

csiph-web