Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1165004 > unrolled thread
| Started by | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| First post | 2015-06-15 05:40 +0200 |
| Last post | 2015-06-15 05:40 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] ARM: orion5x: Use vsprintf %pM extension Andrew Lunn <andrew@lunn.ch> - 2015-06-15 05:40 +0200
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2015-06-15 05:40 +0200 |
| Subject | Re: [PATCH] ARM: orion5x: Use vsprintf %pM extension |
| Message-ID | <pBtpD-8eb-7@gated-at.bofh.it> |
On Sun, Jun 14, 2015 at 07:01:30PM -0700, Joe Perches wrote:
> Format mac addresses with the normal kernel extension.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Andrew
> ---
> arch/arm/mach-orion5x/dns323-setup.c | 4 +---
> arch/arm/mach-orion5x/tsx09-common.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-orion5x/dns323-setup.c b/arch/arm/mach-orion5x/dns323-setup.c
> index 09d2a26..f267e58 100644
> --- a/arch/arm/mach-orion5x/dns323-setup.c
> +++ b/arch/arm/mach-orion5x/dns323-setup.c
> @@ -236,9 +236,7 @@ static int __init dns323_read_mac_addr(void)
> }
>
> iounmap(mac_page);
> - printk("DNS-323: Found ethernet MAC address: ");
> - for (i = 0; i < 6; i++)
> - printk("%.2x%s", addr[i], (i < 5) ? ":" : ".\n");
> + printk("DNS-323: Found ethernet MAC address: %pM\n", addr);
>
> memcpy(dns323_eth_data.mac_addr, addr, 6);
>
> diff --git a/arch/arm/mach-orion5x/tsx09-common.c b/arch/arm/mach-orion5x/tsx09-common.c
> index 7189827..24b2959 100644
> --- a/arch/arm/mach-orion5x/tsx09-common.c
> +++ b/arch/arm/mach-orion5x/tsx09-common.c
> @@ -101,9 +101,7 @@ static int __init qnap_tsx09_check_mac_addr(const char *addr_str)
> addr[i] = byte;
> }
>
> - printk(KERN_INFO "tsx09: found ethernet mac address ");
> - for (i = 0; i < 6; i++)
> - printk("%.2x%s", addr[i], (i < 5) ? ":" : ".\n");
> + printk(KERN_INFO "tsx09: found ethernet mac address %pM\n", addr);
>
> memcpy(qnap_tsx09_eth_data.mac_addr, addr, 6);
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to top | Article view | linux.kernel
csiph-web