Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1163752

Re: [PATCH] extcon: Redefine the unique id of supported external connectors without 'enum extcon' type

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] extcon: Redefine the unique id of supported external connectors without 'enum extcon' type
Date 2015-06-12 06:30 +0200
Message-ID <pAoLn-2R1-3@gated-at.bofh.it> (permalink)
References <pAmJz-8n7-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jun 12, 2015 at 11:10:06AM +0900, Chanwoo Choi wrote:
> This patch just redefine the unique id of supported external connectors without
> 'enum extcon' type. Because unique id would be used on devictree file(*.dts) to
> indicate the specific external connectors like key number of input framework.
> So, I have the plan to move this definitions to following header file which
> includes the unique id of supported external connectors.
> - include/dt-bindings/extcon/extcon.h

Do we have other such fields in dt-bindings that are not enumerated
types?

What's wrong with keeping this as-is and not changing to an integer?

> Fixes: 2a9de9c0f08d ("extcon: Use the unique id for external connector instead of string")

How is this a bugfix?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] extcon: Redefine the unique id of supported external  connectors without 'enum extcon' type Chanwoo Choi <cw00.choi@samsung.com> - 2015-06-12 04:20 +0200
  Re: [PATCH] extcon: Redefine the unique id of supported external  connectors without 'enum extcon' type Greg KH <gregkh@linuxfoundation.org> - 2015-06-12 06:30 +0200
    Re: [PATCH] extcon: Redefine the unique id of supported external  connectors without 'enum extcon' type Chanwoo Choi <cw00.choi@samsung.com> - 2015-06-12 07:10 +0200
  Re: [PATCH] extcon: Redefine the unique id of supported external  connectors without 'enum extcon' type Greg KH <gregkh@linuxfoundation.org> - 2015-06-12 06:30 +0200
    Re: [PATCH] extcon: Redefine the unique id of supported external  connectors without 'enum extcon' type Chanwoo Choi <cw00.choi@samsung.com> - 2015-06-12 06:50 +0200

csiph-web