Re: [PATCH non-pretimeout 4/7] Watchdog: introduce ARM SBSA watchdog driver

From	Timur Tabi <timur@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH non-pretimeout 4/7] Watchdog: introduce ARM SBSA watchdog driver
Date	2015-06-12 06:00 +0200
Message-ID	<pAoim-214-5@gated-at.bofh.it> (permalink)
References	<pqlF8-659-23@gated-at.bofh.it> <pzSit-503-9@gated-at.bofh.it> <pzSsa-5bn-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

fu.wei@linaro.org wrote:
> +	if (timeout <= gwdt->max_wor_timeout)
> +		writel_relaxed(timeout * gwdt->clk,
> +			       gwdt->control_base + SBSA_GWDT_WOR);
> +	else
> +		writel_relaxed(gwdt->max_wor_timeout * gwdt->clk,
> +			       gwdt->control_base + SBSA_GWDT_WOR);

You pre-calculate the maximum timeout possible already, so why do you 
need the if-statement?

Frankly, your non-pretimeout driver is almost identical to mine, which 
was posted weeks ago.  At this point, you're really just copying my 
driver but putting your name on it.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH non-pretimeout 4/7] Watchdog: introduce ARM SBSA  watchdog driver Timur Tabi <timur@codeaurora.org> - 2015-06-12 06:00 +0200
  Re: [PATCH non-pretimeout 4/7] Watchdog: introduce ARM SBSA watchdog driver Fu Wei <fu.wei@linaro.org> - 2015-06-14 12:20 +0200

csiph-web