Re: [PATCH] extcon: Redefine the unique id of supported external connectors without 'enum extcon' type

From	Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] extcon: Redefine the unique id of supported external connectors without 'enum extcon' type
Date	2015-06-12 06:50 +0200
Message-ID	<pAp4K-3dQ-7@gated-at.bofh.it> (permalink)
References	<pAmJz-8n7-3@gated-at.bofh.it> <pAoLn-2R1-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Dear Greg,

On 06/12/2015 01:27 PM, Greg KH wrote:
> On Fri, Jun 12, 2015 at 11:10:06AM +0900, Chanwoo Choi wrote:
>> This patch just redefine the unique id of supported external connectors without
>> 'enum extcon' type. Because unique id would be used on devictree file(*.dts) to
>> indicate the specific external connectors like key number of input framework.
>> So, I have the plan to move this definitions to following header file which
>> includes the unique id of supported external connectors.
>> - include/dt-bindings/extcon/extcon.h
>>
>> Fixes: 2a9de9c0f08d ("extcon: Use the unique id for external connector instead of string")
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> Dear Greg,
>>
>> I sent pull-request[1] of extcon for 4.2. This patch[2] in the pull-request[2]
>> includes the one issue about 'enum extcon'. The 'enum extcon' type is ambiguous
>> and not clear. So, if you possible, I hope you to pick this patch on char-misc
>> git repository.
> 
> I don't understand, I took that pull request, right?
> 
> What does that have to do with this patch?

This patch is based on patch[1] and then patch[1] was merged on char-misc-next branch (char-misc.git) through pull request.
[1] 2a9de9c0f08d ("extcon: Use the unique id for external connector instead of string")

So, after reviewing this patch by you,
if this patch is ok, I hope that this patch will be applied to char-misc-next branch.

I'm sorry about un-clear explanation.

Best Regards,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] extcon: Redefine the unique id of supported external  connectors without 'enum extcon' type Chanwoo Choi <cw00.choi@samsung.com> - 2015-06-12 04:20 +0200
  Re: [PATCH] extcon: Redefine the unique id of supported external  connectors without 'enum extcon' type Greg KH <gregkh@linuxfoundation.org> - 2015-06-12 06:30 +0200
    Re: [PATCH] extcon: Redefine the unique id of supported external  connectors without 'enum extcon' type Chanwoo Choi <cw00.choi@samsung.com> - 2015-06-12 07:10 +0200
  Re: [PATCH] extcon: Redefine the unique id of supported external  connectors without 'enum extcon' type Greg KH <gregkh@linuxfoundation.org> - 2015-06-12 06:30 +0200
    Re: [PATCH] extcon: Redefine the unique id of supported external  connectors without 'enum extcon' type Chanwoo Choi <cw00.choi@samsung.com> - 2015-06-12 06:50 +0200

csiph-web