Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1163606

Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code
Date Thu, 11 Jun 2015 22:50:03 +0200
Message-ID <pAhAf-fl-53@gated-at.bofh.it> (permalink)
References <pAbl8-7YY-5@gated-at.bofh.it> <pAbl8-7YY-27@gated-at.bofh.it> <pAhqx-8v7-1@gated-at.bofh.it>
X-Original-To Ingo Molnar <mingo@kernel.org>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=0ibMmTRWy6l0GR9JTVsWoWiBF0e/JGrylBYbnjzUld8=; b=aPtcAjgH0QLLjakQgUf/thAfNPoI96fwvmvpm9DFXeznBnCDm5eyFM6Z27jBtBLz3K URakSwuJF75i2r3dP/RhiP8GjmTFzshB3B68Qi3P0LH8y3Pol6DT9vf6gHAVEfe2OVMh zIBwVKzFapM/nSJjbwXbynxDCF0DyHc9pLWFSZeDBkFCaIbO09Rjr/4iXD3DxXWeyQl6 Ze1TTV5qyOrKigddv9suM71uL4ZWC9tTskPqoj0VdKd0Biw02g+kB5nKnZvNR9IkuOss Zia7rcPao0rS24m0pDEcq5AOXZ+/EQjIWc4JMQaVV8aK8YhaB8iw+S4S4vu9/zOkOL4f yCcg==
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=0ibMmTRWy6l0GR9JTVsWoWiBF0e/JGrylBYbnjzUld8=; b=NPNlmooPMmXPbM5+WCKPG8B6dgGj2ugztFWXSr0TW5tUYTTzDj9azQa/J5UE7MnxvB pin7OnUC4czeC+prVEHxjlFyD5OBr8XUrWFOGe2Qzg9gVjruy+1C9pdgLiW8lRK7ZN8F 2IF0uRPhJA/vxU0092T/lCt52X/ClsEkawHLY=
MIME-Version 1.0
X-Received by 10.43.173.70 with SMTP id ob6mr12941887icc.45.1434055287502; Thu, 11 Jun 2015 13:41:27 -0700 (PDT)
X-Google-Sender-Auth Kkfo-d80p5VcEcrKyJxIVbeTBE4
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 22
Organization linux.* mail to news gateway
X-Original-Cc Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-mml@vger.kernel.org, Andy Lutomirski <luto@amacapital.net>, Andrew Morton <akpm@linux-foundation.org>, Denys Vlasenko <dvlasenk@redhat.com>, Brian Gerst <brgerst@gmail.com>, Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>, Oleg Nesterov <oleg@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Waiman Long <Waiman.Long@hp.com>
X-Original-Date Thu, 11 Jun 2015 13:41:27 -0700
X-Original-Message-ID <CA+55aFyDp_B9q4ReiMsngzQYTWRukrNBYy7uoGfFQ5nVredT9Q@mail.gmail.com>
X-Original-References <1434031637-9091-1-git-send-email-mingo@kernel.org> <1434031637-9091-8-git-send-email-mingo@kernel.org> <CA+55aFzONQOsVXTECmynSAcDW_WnwOpLHMVDNUp0nsqrkYnw3Q@mail.gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref aioe.org linux.kernel:1163606

Show key headers only | View raw


On Thu, Jun 11, 2015 at 1:37 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Don't use "for_each_process_thread(g, p)". You only care about each
> mm, and threads all share the same mm, so just do
>
>     for_each_process(p)
>
> instead of iterating over all threads too.

Hmm. I may be wrong. It strikes me that one of the group leaders might
have exited but the subthreads live on. We'd see p->mm being NULL,
even though the mm was originally in use.

Ugh. So maybe the code really does need to iterate over all threads.

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the  Xen guest code Linus Torvalds <torvalds@linux-foundation.org> - 2015-06-11 22:40 +0200
  Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the  Xen guest code Linus Torvalds <torvalds@linux-foundation.org> - 2015-06-11 22:50 +0200
    Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from  the Xen guest code Oleg Nesterov <oleg@redhat.com> - 2015-06-13 01:40 +0200
    Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from  the Xen guest code Ingo Molnar <mingo@kernel.org> - 2015-06-13 09:30 +0200
      Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from  the Xen guest code Oleg Nesterov <oleg@redhat.com> - 2015-06-13 20:10 +0200

csiph-web