Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1163606

Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code
Date 2015-06-11 22:50 +0200
Message-ID <pAhAf-fl-53@gated-at.bofh.it> (permalink)
References <pAbl8-7YY-5@gated-at.bofh.it> <pAbl8-7YY-27@gated-at.bofh.it> <pAhqx-8v7-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Jun 11, 2015 at 1:37 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Don't use "for_each_process_thread(g, p)". You only care about each
> mm, and threads all share the same mm, so just do
>
>     for_each_process(p)
>
> instead of iterating over all threads too.

Hmm. I may be wrong. It strikes me that one of the group leaders might
have exited but the subthreads live on. We'd see p->mm being NULL,
even though the mm was originally in use.

Ugh. So maybe the code really does need to iterate over all threads.

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the  Xen guest code Linus Torvalds <torvalds@linux-foundation.org> - 2015-06-11 22:40 +0200
  Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the  Xen guest code Linus Torvalds <torvalds@linux-foundation.org> - 2015-06-11 22:50 +0200
    Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from  the Xen guest code Oleg Nesterov <oleg@redhat.com> - 2015-06-13 01:40 +0200
    Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from  the Xen guest code Ingo Molnar <mingo@kernel.org> - 2015-06-13 09:30 +0200
      Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from  the Xen guest code Oleg Nesterov <oleg@redhat.com> - 2015-06-13 20:10 +0200

csiph-web