Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1163585

Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code
Date 2015-06-11 22:40 +0200
Message-ID <pAhqx-8v7-1@gated-at.bofh.it> (permalink)
References <pAbl8-7YY-5@gated-at.bofh.it> <pAbl8-7YY-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Jun 11, 2015 at 7:07 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> But we want to remove the pgd_list, so convert the code over to walk
> all tasks in the system. This is an equivalent method.

This is not at all equivalent, and it looks stupid.

Don't use "for_each_process_thread(g, p)". You only care about each
mm, and threads all share the same mm, so just do

    for_each_process(p)

instead of iterating over all threads too.

No?

               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the  Xen guest code Linus Torvalds <torvalds@linux-foundation.org> - 2015-06-11 22:40 +0200
  Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the  Xen guest code Linus Torvalds <torvalds@linux-foundation.org> - 2015-06-11 22:50 +0200
    Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from  the Xen guest code Oleg Nesterov <oleg@redhat.com> - 2015-06-13 01:40 +0200
    Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from  the Xen guest code Ingo Molnar <mingo@kernel.org> - 2015-06-13 09:30 +0200
      Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from  the Xen guest code Oleg Nesterov <oleg@redhat.com> - 2015-06-13 20:10 +0200

csiph-web