Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #8907

Re: Review/sponsorship of osmalchemy package

Show key headers only | View raw

On 09/12/2016 03:39 PM, Dominik George wrote:
> Hi,
> 
> I would like to ask for review and sponsorship of the osmalchemy package.
> 
> It can be found in the usual place at:
> git.debian.org:/git/python-modules/packages/osmalchemy.git
> 
> The package can be build with gbp using pristine-tar. It appears to be
> lintian-clean, apart from a missing upstream changelog (which upstream,
> i.e. me, myself and I, will fix in a future release ;)).
> 
> OSMAlchemy will be used in several projects that will run on Debian;
> it was also feaured at the Python Unconference in Germany last weekend
> and many people like it and would like to use it, so adding it to Debian
> seems legit (it has also a quite low impact on the repo, as it has only
> few dependencies, so nothing bad to expect there).
> 
> Thanks in advance for looking at the package,
> Nik

Here's my comments.

debian/changelog:
=================
* Please just write "Initial debian release".

debian/control:
===============
* Please remove "X-Python3-Version: >= 3.2". Even Jessie has Python 3.2,
so we really don't need to set such lower bound.

* Please set "Priority: extra" and not optional.

* You may want to run "wrap-and-sort -t -a" to clean-up your
debian/control fields (YMMV).

debian/copyright:
=================
* There's multiple MIT licenses. Therefore, the most common MIT license,
we call it "Expat" in Debian (not sure why, but it's like that...). So
please replace MIT by Expat.

debian/docs:
============
* It looks like the README.rst could be transformed into .html using
sphinx. Could you do that? It'd look a lot nicer.

debian/python3-osmalchemy.lintian-overrides:
============================================
* Why do you think you need such a file? The issue is there, it's not a
false positive, so just leave lintian complain. It gives a warning, not
a hard error, so that's fine.

Everything else looked ok to me, though it was only a quick look...

Cheers,

Thomas Goirand (zigo)

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Review/sponsorship of osmalchemy package Dominik George <nik@naturalnet.de> - 2016-09-12 15:40 +0200
  Re: Review/sponsorship of osmalchemy package Thomas Goirand <zigo@debian.org> - 2016-09-28 00:50 +0200
    [WAS: Re: Review/sponsorship of osmalchemy package] md , rst, txt,  html, ... Jerome BENOIT <sphericaltriangle@rezozer.net> - 2016-09-28 01:30 +0200
      Re: [WAS: Re: Review/sponsorship of osmalchemy package] md , rst,  txt, html, ... Guido van Steen <vansteen@users.sourceforge.net> - 2016-09-28 08:30 +0200
    Re: Review/sponsorship of osmalchemy package Piotr Ożarowski <piotr@debian.org> - 2016-09-28 11:40 +0200
      Re: Review/sponsorship of osmalchemy package Bernd Zeimetz <bernd@bzed.de> - 2016-10-02 23:30 +0200
        Re: Review/sponsorship of osmalchemy package Piotr Ożarowski <piotr@debian.org> - 2016-10-03 10:20 +0200
          Re: Review/sponsorship of osmalchemy package Sebastian Ramacher <sramacher@debian.org> - 2016-10-03 10:30 +0200
            Re: Review/sponsorship of osmalchemy package Piotr Ożarowski <piotr@debian.org> - 2016-10-03 11:20 +0200
              Re: Review/sponsorship of osmalchemy package Sebastian Ramacher <sramacher@debian.org> - 2016-10-03 11:30 +0200
          Re: Review/sponsorship of osmalchemy package Bernd Zeimetz <bernd@bzed.de> - 2016-10-22 21:50 +0200
    Re: Review/sponsorship of osmalchemy package Dmitry Shachnev <mitya57@debian.org> - 2016-09-28 14:30 +0200
      Re: Review/sponsorship of osmalchemy package Piotr Ożarowski <piotr@debian.org> - 2016-09-28 14:40 +0200

csiph-web