Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.maint.python > #15012
| Path | csiph.com!fu-berlin.de!bofh.it!news.nic.it!robomod |
|---|---|
| From | Jeroen Ploemen <jcfp@debian.org> |
| Newsgroups | linux.debian.maint.python |
| Subject | review for python-sepaxml/2.6.1-1 |
| Date | Tue, 23 May 2023 16:10:01 +0200 |
| Message-ID | <GyAS5-aU23-9@gated-at.bofh.it> (permalink) |
| X-Original-To | matthias.geiger1024@tutanota.de |
| X-Mailbox-Line | From debian-python-request@lists.debian.org Tue May 23 14:03:10 2023 |
| Old-Return-Path | <jcfp@debian.org> |
| X-Amavis-Spam-Status | No, score=-114.58 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DIGITS_LETTERS=1, DKIMWL_WL_HIGH=-0.161, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, LDO_WHITELIST=-5, MD5_SHA1_SUM=-1, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no |
| X-Mailer | Claws Mail 4.1.1 (GTK 3.24.33; x86_64-pc-linux-gnu) |
| MIME-Version | 1.0 |
| Content-Type | multipart/signed; boundary="Sig_/WaoG_PLHHw/JCNmI9HU2JB5"; protocol="application/pgp-signature"; micalg=pgp-sha512 |
| X-Debian-User | jcfp |
| X-Mailing-List | <debian-python@lists.debian.org> archive/latest/20922 |
| List-ID | <debian-python.lists.debian.org> |
| List-URL | <https://lists.debian.org/debian-python/> |
| List-Archive | https://lists.debian.org/msgid-search/20230523160231.536aac5d@debian.org |
| Approved | robomod@news.nic.it |
| Lines | 81 |
| Organization | linux.* mail to news gateway |
| Sender | robomod@news.nic.it |
| X-Original-Cc | debian-python@lists.debian.org |
| X-Original-Date | Tue, 23 May 2023 16:02:31 +0200 |
| X-Original-Message-ID | <20230523160231.536aac5d@debian.org> |
| Xref | csiph.com linux.debian.maint.python:15012 |
Show key headers only | View raw
[Multipart message — attachments visible in raw view] - view raw
hi Matthias, the package looks mostly fine on the technical side, with only some minor issues and suggestions for improvement of d/control and d/rules. The copyright file does need attention though, also in light of recent upstream commits that made significant changes. A fresh upstream release including these changes would be beneficial, if only to avoid confusion. copyright: * years? 2012-2013 in upstream license file vs -2022 in d/copyright; also see recent upstream changes that use 2017 instead as the starting point for their copyright claim [1]. * copyright for congressus apparently applies to more files, see [1]. * no info listed for the schema files in sepaxml/schemas/; you'll have to verify any third parties that may be involved haven't put restrictions on commercial use, development of software and/or services competing with their own, etc, in possible violation of the DFSG: see [2] and the third-party statements linked from [3]. control: * unused build-deps: isort, flake8? * please mark test-only build-deps as such (i.e. !nocheck). * long descr.: consider turning that list of standards into an actual list to improve readability. * long descr.: you may want to write out SEPA once upon first use, introducing the abbreviation; also makes it easier to find when users search for that. * long descr.: no need to mention the module is installed for Python 3 nowadays, that used to be a thing when Python 2 was still around and packages actually had to support both. rules: * "export PYBUILD_NAME=python-sepaxml" - is it? See [4]. autopkgtest: please include a non-trivial autopkgtest; for packages with a pytest-based tests such as this one, running the upstream test suite in an autopkgtest context is usually straightforward and these days can even be done automagically with pybuild-autopkgtest [5]. lintian hits: I: python3-sepaxml: capitalization-error-in-description python Python I: python3-sepaxml: capitalization-error-in-description-synopsis python Python [1]https://github.com/raphaelm/python-sepaxml/commit/04171a615eb4e056bb5e326d77879d3e0cfd3f12 [2]https://github.com/raphaelm/python-sepaxml/commit/b92f92f4bfd5de6ed31d3c1ef3b82f5d7c4bf9d8 [3]https://www.iso20022.org/terms-use [4]https://wiki.debian.org/Python/Pybuild#debian.2Frules [5]https://manpages.debian.org/testing/dh-python/pybuild-autopkgtest.1.en.html
Back to linux.debian.maint.python | Previous | Next | Find similar | Unroll thread
review for python-sepaxml/2.6.1-1 Jeroen Ploemen <jcfp@debian.org> - 2023-05-23 16:10 +0200
csiph-web