Path: csiph.com!fu-berlin.de!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: review for python-sepaxml/2.6.1-1 Date: Tue, 23 May 2023 16:10:01 +0200 Message-ID: X-Original-To: matthias.geiger1024@tutanota.de X-Mailbox-Line: From debian-python-request@lists.debian.org Tue May 23 14:03:10 2023 Old-Return-Path: X-Amavis-Spam-Status: No, score=-114.58 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DIGITS_LETTERS=1, DKIMWL_WL_HIGH=-0.161, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, LDO_WHITELIST=-5, MD5_SHA1_SUM=-1, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.1.1 (GTK 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/WaoG_PLHHw/JCNmI9HU2JB5"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/20922 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20230523160231.536aac5d@debian.org Approved: robomod@news.nic.it Lines: 81 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Tue, 23 May 2023 16:02:31 +0200 X-Original-Message-ID: <20230523160231.536aac5d@debian.org> Xref: csiph.com linux.debian.maint.python:15012 --Sig_/WaoG_PLHHw/JCNmI9HU2JB5 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable hi Matthias, the package looks mostly fine on the technical side, with only some minor issues and suggestions for improvement of d/control and d/rules. The copyright file does need attention though, also in light of recent upstream commits that made significant changes. A fresh upstream release including these changes would be beneficial, if only to avoid confusion. copyright: * years? 2012-2013 in upstream license file vs -2022 in d/copyright; also see recent upstream changes that use 2017 instead as the starting point for their copyright claim [1]. * copyright for congressus apparently applies to more files, see [1]. * no info listed for the schema files in sepaxml/schemas/; you'll have to verify any third parties that may be involved haven't put restrictions on commercial use, development of software and/or services competing with their own, etc, in possible violation of the DFSG: see [2] and the third-party statements linked from [3]. control: * unused build-deps: isort, flake8? * please mark test-only build-deps as such (i.e. !nocheck). * long descr.: consider turning that list of standards into an actual list to improve readability. * long descr.: you may want to write out SEPA once upon first use, introducing the abbreviation; also makes it easier to find when users search for that. * long descr.: no need to mention the module is installed for Python 3 nowadays, that used to be a thing when Python 2 was still around and packages actually had to support both. rules: * "export PYBUILD_NAME=3Dpython-sepaxml" - is it? See [4]. autopkgtest: please include a non-trivial autopkgtest; for packages with a pytest-based tests such as this one, running the upstream test suite in an autopkgtest context is usually straightforward and these days can even be done automagically with pybuild-autopkgtest [5]. lintian hits: I: python3-sepaxml: capitalization-error-in-description python Python=20 I: python3-sepaxml: capitalization-error-in-description-synopsis python Pyt= hon [1]https://github.com/raphaelm/python-sepaxml/commit/04171a615eb4e056bb5e32= 6d77879d3e0cfd3f12 [2]https://github.com/raphaelm/python-sepaxml/commit/b92f92f4bfd5de6ed31d3c= 1ef3b82f5d7c4bf9d8 [3]https://www.iso20022.org/terms-use [4]https://wiki.debian.org/Python/Pybuild#debian.2Frules [5]https://manpages.debian.org/testing/dh-python/pybuild-autopkgtest.1.en.h= tml --Sig_/WaoG_PLHHw/JCNmI9HU2JB5 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmRsx3cACgkQQoMEoXSN zHoHpw//ZUYAhy7+gTk+533f+JHV72PM85aR1E7fLSw0f3gYVW+wQ7oNmf4cu9ow z7UzeEyaAULaehi5d/gTlCa+Sf6izBoNNJuLas3ubEVp9jjTHMlvrkxEuJMtTqMZ Of2Y4eDhjpG9v2Qtyq5Wgr/CEMqNEJ9LjvVjxgYbCC9TZtjeu7KaGVfXkvvX7yeN B10FYveo6NrP3hpMeM6T4k3W8smWf9lOG9vq6UZsaCcAcfy+3pfrYatqNbmaVkjA E6C7G55KWgb/dbWVA2C5hpS6awOTLAhX23LO7FOZqMvHOplW6dNv81p3fB4LqaZU gWPy+dpYJmVkGbBTZGlfYlbzEt0MVYKwu9FbSGsfGbiGZ8OaZk0pZ9OQSxUEFLMK s+KAMy266f/j1KzSIihXk9BxWdDZx5TNEe2YjrrSSlCKiwgPbOqvdTWa304otV/x k6QJyNG7ViH3vP7qtekNm3J/OJ7/T50FKh/OxtJFYFwdHgm9WaKzbXzvJiVUZE6S 0Glq1B1aOq2Q49NnkuedzAm2BWxvHL29xlZ5i7jwKveErVFoiMG55HLKwv4bGbq1 LsHNuYBo7cELe6wjInfyZ08WFm9vvpBmrwUPIiv5eKLrhivUgV5e7KPuAIcPOmBV +zI56ejxNFgz1cV25lPLKo6Wf//8mlve19rFj2l/lQEmGaZPyJU= =/Uxe -----END PGP SIGNATURE----- --Sig_/WaoG_PLHHw/JCNmI9HU2JB5--