Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #15012 > unrolled thread

review for python-sepaxml/2.6.1-1

Back to article view | Back to linux.debian.maint.python

Contents

  review for python-sepaxml/2.6.1-1 Jeroen Ploemen <jcfp@debian.org> - 2023-05-23 16:10 +0200

#15012 — review for python-sepaxml/2.6.1-1

[Multipart message — attachments visible in raw view] — view raw

hi Matthias,

the package looks mostly fine on the technical side, with only some
minor issues and suggestions for improvement of d/control and d/rules.

The copyright file does need attention though, also in light of
recent upstream commits that made significant changes. A fresh
upstream release including these changes would be beneficial, if only
to avoid confusion.

copyright:
 * years? 2012-2013 in upstream license file vs -2022 in d/copyright;
   also see recent upstream changes that use 2017 instead as the
   starting point for their copyright claim [1].
 * copyright for congressus apparently applies to more files, see [1].
 * no info listed for the schema files in sepaxml/schemas/; you'll
   have to verify any third parties that may be involved haven't put
   restrictions on commercial use, development of software and/or
   services competing with their own, etc, in possible violation of
   the DFSG: see [2] and the third-party statements linked from [3].
control:
 * unused build-deps: isort, flake8?
 * please mark test-only build-deps as such (i.e. !nocheck).
 * long descr.: consider turning that list of standards into an actual
   list to improve readability.
 * long descr.: you may want to write out SEPA once upon first use,
   introducing the abbreviation; also makes it easier to find when
   users search for that.
 * long descr.: no need to mention the module is installed for Python
   3 nowadays, that used to be a thing when Python 2 was still around
   and packages actually had to support both.
rules:
 * "export PYBUILD_NAME=python-sepaxml" - is it? See [4].

autopkgtest:
please include a non-trivial autopkgtest; for packages with a
pytest-based tests such as this one, running the upstream test suite
in an autopkgtest context is usually straightforward and these days
can even be done automagically with pybuild-autopkgtest [5].

lintian hits:
I: python3-sepaxml: capitalization-error-in-description python Python 
I: python3-sepaxml: capitalization-error-in-description-synopsis python Python


[1]https://github.com/raphaelm/python-sepaxml/commit/04171a615eb4e056bb5e326d77879d3e0cfd3f12
[2]https://github.com/raphaelm/python-sepaxml/commit/b92f92f4bfd5de6ed31d3c1ef3b82f5d7c4bf9d8
[3]https://www.iso20022.org/terms-use
[4]https://wiki.debian.org/Python/Pybuild#debian.2Frules
[5]https://manpages.debian.org/testing/dh-python/pybuild-autopkgtest.1.en.html

[toc] | [standalone]

Back to top | Article view | linux.debian.maint.python

csiph-web